improve retrieving of session related environment variables #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using env in the timeshift-launcher like proposed in linuxmint#384, the timeshift process itself now searches its parents until it finds a process that is not owned by the same user as timeshift (root) and then copies interesting environment variables from there. This allows pkexec to handle the command correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using env in the timeshift-launcher like proposed in #384, the timeshift process itself now searches its parents until it finds a process that is not owned by the same user as timeshift (root) and then copies interesting environment variables from there. This allows pkexec to handle the command correctly.
This should fix: #452
And: #450
It might also be interesting for #459 as it allows us to use the original
$DBUS_SESSION_BUS_ADDRESSI know this kinda breaks some principles. But i guess that is the price you have to pay if you want to run a root process in a user session. Maybe timeshift should be moved to a server/client approach (similar to modemmanager) where we have a daemon that is root and a client that can be run by a user and then communicate using system-dbus objects. That would also allow us to have multiple timeshift actions running at the same time. But i guess that would be a bigger topic for another time.