Skip to content

Conversation

@Shyliuli
Copy link
Contributor

@Shyliuli Shyliuli commented Jan 7, 2025

This PR introduces updates to ensure proper handling of the DISPLAY and XAUTHORITY environment variables when executing commands with pkexec.

@Shyliuli
Copy link
Contributor Author

Shyliuli commented Jan 7, 2025

pkexec removes most environment variables, which can prevent Timeshift from starting on some distributions. For example: https://www.reddit.com/r/voidlinux/comments/t1f2it/timeshift_gui_error_gtkwarning_cannot_open_display/?rdt=35784

@mtwebster mtwebster merged commit 98af104 into linuxmint:master Jul 28, 2025
ygerlach added a commit to ygerlach/timeshift that referenced this pull request Oct 5, 2025
instead of using env in the timeshift-launcher like proposed in linuxmint#384, the timeshift process itself now searches its parents until it finds a process that is not owned by the same user as timeshift (root) and then copies interesting environment variables from there. This allows pkexec to handle the command correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants