Skip to content

JobPodReplacementPolicy Promoted To GA Blog Post #51426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2025
Merged

JobPodReplacementPolicy Promoted To GA Blog Post #51426

merged 3 commits into from
Aug 17, 2025

Conversation

@dejanzele
Copy link
Contributor

@dejanzele dejanzele commented Jun 29, 2025

Description

This PR will include a blog post on the latest state of Job Pod Replacement Policy feature gate (GA) as of k8s v1.34.

Issue

KEP: kubernetes/enhancements#3939

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2025
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2025
@aibarbetta
Copy link
Member

aibarbetta commented Jul 7, 2025

Hi @wongchar @dejanzele 👋 this is Agus from the v1.34 Communications Team!

@wongchar as author of #51484, I'd like you to be a writing buddy for @dejanzele on this PR.

Please:

  • Review this PR, paying attention to the guidelines and review hints
  • Update your own PR based on any best practices you identify that should be applied
  • Remember to be compassionate with your fellow article author

@aibarbetta aibarbetta mentioned this pull request Jul 7, 2025
Merged
@aibarbetta
Copy link
Member

aibarbetta commented Jul 13, 2025

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 13, 2025
@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from e8a9017 to 8426c7b Compare July 23, 2025 21:46
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2025
@dejanzele dejanzele changed the title [WIP] JobPodReplacementPolicy Promoted To GA Blog Post JobPodReplacementPolicy Promoted To GA Blog Post Jul 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2025
@dejanzele dejanzele changed the base branch from main to dev-1.34 July 23, 2025 21:51
@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from 8426c7b to b0c1b60 Compare July 23, 2025 21:58
@netlify
Copy link

netlify bot commented Jul 23, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 136e7e8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6886c9983458060008cac435

@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from b0c1b60 to 6c4a676 Compare July 23, 2025 22:15
@netlify
Copy link

netlify bot commented Jul 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f5954cd
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/689d22ea0c568d0009ac52a5
😎 Deploy Preview https://deploy-preview-51426--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dejanzele
Copy link
Contributor Author

dejanzele commented Jul 24, 2025

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo July 24, 2025 10:28
@lmktfy
Copy link
Member

lmktfy commented Jul 24, 2025

@wongchar – did you take a look at this? What are your thoughts?

@dejanzele dejanzele mentioned this pull request Jul 24, 2025
Closed
16 tasks
wongchar
wongchar reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@wongchar wongchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dejanzele @lmktfy

left some minor comments regarding links to other files. Otherwise, makes sense and looks good!

@aibarbetta
Copy link
Member

aibarbetta commented Jul 28, 2025

Hi @dejanzele 👋 -- this is Agus from the v1.34 Communications Team!

Just a friendly reminder that we are approaching the feature blog "ready for review" deadline: Friday 8th August 2025. We ask you to have the blog in non-draft state, and all write-up to be complete.

If you have any questions or need help, please don't hesitate to reach out to me or any of the Communications Team members. We are here to help you!

aibarbetta
aibarbetta reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@aibarbetta aibarbetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR to merge into kubernetes:main (not kubernetes:dev.1-34)

@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from 6c4a676 to 136e7e8 Compare July 28, 2025 00:51
@dejanzele dejanzele changed the base branch from dev-1.34 to main July 28, 2025 00:51
@dejanzele
Copy link
Contributor Author

dejanzele commented Aug 11, 2025

Hi @aibarbetta,

Thanks for the feedback, I've addressed all comments.

I have posted this PR in the sig-apps channel if anybody else is interested in taking a look.

@mimowo
Copy link
Contributor

mimowo commented Aug 11, 2025

LGTM (from technical PoV)👍

@mimowo
Copy link
Contributor

mimowo commented Aug 12, 2025

cc @atiratree @soltysh @kannon92 ptal

@Serenity611
Copy link
Contributor

Serenity611 commented Aug 12, 2025

Reviewed from general proofreading / formatting perspective, looks great!

@aibarbetta
Copy link
Member

aibarbetta commented Aug 12, 2025

Buddy, comms, and SIG reviewed, assigning SIG Doc Blogs to review
/assign @nate-double-u

lmktfy
lmktfy reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must fix the hyperlinks (check https://deploy-preview-51426--kubernetes-io-main-staging.netlify.app/blog/1/01/01/kubernetes-v1-34-pod-replacement-policy-for-jobs-goes-ga/); other snags are less important and don't really block a merge.

@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from c8683f3 to e2020e0 Compare August 13, 2025 08:42
@dejanzele
fix wording and some nits
6c97965 
Signed-off-by: Dejan Zele Pejchev <[email protected]>
soltysh
soltysh reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits from me, and mostly comments from Tim.

From tech pov, with my sig-apps hat, it's good.

@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch 2 times, most recently from 82cbc74 to 9eaae04 Compare August 13, 2025 23:38
@dejanzele dejanzele force-pushed the promote-jobs-podreplacementpolicy-to-ga branch from 9eaae04 to f5954cd Compare August 13, 2025 23:42
soltysh
soltysh approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 14, 2025

LGTM label has been added.

Git tree hash: 538323516d30011e14b48971a39cd394c4d10d10

@soltysh
Copy link
Contributor

soltysh commented Aug 14, 2025

The current example is great! Thank you 😄

@aibarbetta
Copy link
Member

aibarbetta commented Aug 16, 2025

@lmktfy I believe this is ok to merge, can you take a look?

@lmktfy
Copy link
Member

lmktfy commented Aug 17, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit c566908 into kubernetes:main Aug 17, 2025
6 checks passed
This was referenced Aug 30, 2025
Merged
Merged
@Serenity611 Serenity611 mentioned this pull request Nov 14, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

+4 more reviewers

@aibarbetta aibarbetta aibarbetta left review comments

@mimowo mimowo mimowo left review comments

@wongchar wongchar wongchar left review comments

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@nate-double-u nate-double-u

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dejanzele @aibarbetta @lmktfy @mimowo @Serenity611 @k8s-ci-robot @soltysh @wongchar @nate-double-u