Skip to content

Conversation

@graz-dev
Copy link
Contributor

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Add writing buddy assignment process to comms handbook

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-team Issues or PRs related to the release-team subproject needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2025
Copy link
Member

@aibarbetta aibarbetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @graz-dev! I left some comments, sorry for the delayed review

@justaugustus
Copy link
Member

/assign @katcosgrove

@katcosgrove
Copy link
Contributor

/lgtm

I like this change!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@aibarbetta
Copy link
Member

/lgtm
Thank you for the fixes @graz-dev!

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

(on behalf of blog team)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: graz-dev, lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9d8e758 into kubernetes:master Sep 20, 2025
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 20, 2025
Comment on lines +10 to +14
Please:
- Review this PR, paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review)
- Update your own PR based on any best practices you identify that should be applied
- Remember to be compassionate with your fellow article author
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this, but we could tweak it.

Suggested change
Please:
- Review this PR, paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review)
- Update your own PR based on any best practices you identify that should be applied
- Remember to be compassionate with your fellow article author
Please:
- Get in touch with your buddy and find out how they want to work - either using a Google Doc, HackMD, or just directly with a pull request.
- Once they have got a PR that is ready for review, then please review it (this PR), paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review)
- Update your own PR based on any best practices you identify that should be applied
- Remember to be compassionate with your fellow article author

@lmktfy
Copy link
Member

lmktfy commented Sep 20, 2025

TBH I didn't know I was an approver for this. If this merged too early, we can revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants