-
Notifications
You must be signed in to change notification settings - Fork 429
Add writing buddy assignment process #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
release-team/role-handbooks/communications/templates/writing-buddy-assignment.md
Outdated
Show resolved
Hide resolved
aibarbetta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this @graz-dev! I left some comments, sorry for the delayed review
release-team/role-handbooks/communications/templates/writing-buddy-assignment.md
Outdated
Show resolved
Hide resolved
release-team/role-handbooks/communications/templates/writing-buddy-assignment.md
Outdated
Show resolved
Hide resolved
|
/assign @katcosgrove |
|
/lgtm I like this change! |
|
/lgtm |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
(on behalf of blog team)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: graz-dev, lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| Please: | ||
| - Review this PR, paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review) | ||
| - Update your own PR based on any best practices you identify that should be applied | ||
| - Remember to be compassionate with your fellow article author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change this, but we could tweak it.
| Please: | |
| - Review this PR, paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review) | |
| - Update your own PR based on any best practices you identify that should be applied | |
| - Remember to be compassionate with your fellow article author | |
| Please: | |
| - Get in touch with your buddy and find out how they want to work - either using a Google Doc, HackMD, or just directly with a pull request. | |
| - Once they have got a PR that is ready for review, then please review it (this PR), paying attention to the [guidelines](https://kubernetes.io/docs/contribute/blog/guidelines/) and [review hints](https://kubernetes.io/docs/contribute/blog/writing-buddy/#pull-request-review) | |
| - Update your own PR based on any best practices you identify that should be applied | |
| - Remember to be compassionate with your fellow article author |
|
TBH I didn't know I was an approver for this. If this merged too early, we can revert it. |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Add writing buddy assignment process to comms handbook