-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-1948: Device Plugin API feature: Adding KEP for allowing deallocate in device plugin API call (take over) #3074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @Windrow14! |
|
Hi @Windrow14. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Windrow14 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I signed it |
|
#1949 is revived, so close this one. |
One-line PR description: Take over KEP-1948: Adding KEP for allowing deallocate in device plugin API call #1949, since former author @mewais was no longer responding.
Issue link: Device Plugin API feature: Add Deallocate and PostStopContainer to device plugin API #1948
Other comments:
A comment from @klueska to address: KEP-1948: Adding KEP for allowing deallocate in device plugin API call #1949 (comment). We can do further discussion here.
CC:@fujitatomoya, @FengGaoCSC, @romoh, @bart0sh