Skip to content

Commit a74c791

Browse files
committed
Update design plan and versions for 1948
1 parent 54e07e3 commit a74c791

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

keps/sig-node/1948-add-deallocate-to-device-plugin-api/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,10 @@ Only risk is breaking existing device plugins by introducing non optional change
100100

101101
## Design Details
102102

103-
- Remove reusable devices from `devicemanage`. Reusable devices are silently reused by kubernetes, and so they can't be reported back to device plugins for cleanup, tracking, etc.
104103
- Move `PreStartContainer` in `DeviceManager` to be used as a container lifecycle hook. (This change isn't truly required, but useful for compatibility and organization with the next steps).
105104
- Add `PostStopContainer` and `Deallocate` calls in the DevicePlugin API.
106105
- Add `PostStopContainer` as a container lifecycle hook.
107-
- Add `Deallocate` calls in container manager.
108-
- Delete test cases for reusable devices.
106+
- Add `Deallocate` calls in container manager, taking care to only do so for devices that are no longer in the reuse list.
109107
- Add and modify test cases for both calls.
110108
- Test with existing device plugins to ensure the changes are non-breaking.
111109
- Test with new device plugins utilizing such changes to ensure the changes are working.

keps/sig-node/1948-add-deallocate-to-device-plugin-api/kep.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ replaces: []
2020
stage: alpha
2121

2222
# The milestone at which this feature was, or is targeted to be, at each stage.
23-
latest-milestone: "v1.22"
23+
latest-milestone: "v1.23"
2424
milestone:
25-
alpha: "v1.22"
26-
beta: "v1.23"
27-
stable: "v1.24"
25+
alpha: "v1.23"
26+
beta: "v1.24"
27+
stable: "v1.25"

0 commit comments

Comments
 (0)