- 
                Notifications
    You must be signed in to change notification settings 
- Fork 453
Windows image configuration scripts and Azure builder #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows image configuration scripts and Azure builder #382
Conversation
        
          
                images/capi/ansible/windows/roles/kubernetes/files/StartKubelet.ps1
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                images/capi/ansible/windows/roles/runtimes/tasks/containerd.yml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                images/capi/ansible/windows/roles/runtimes/tasks/containerd.yml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                images/capi/ansible/windows/roles/runtimes/templates/config.toml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | CI is failing with  | 
32c74f9    to
    6d54a94      
    Compare
  
    1e54260    to
    85d41c0      
    Compare
  
    5cff610    to
    7b72c04      
    Compare
  
    47be782    to
    cff124c      
    Compare
  
    | This is ready for final review. I have tested it against a branch on CAPZ and have Windows machines and pods working: This does not include support for running goss. When I tried it out I found native windows support didn't work and opened a PR that will enable it. Once that merges and a new release is cut I can follow up with support. I also have an open question on the location of the Windows ansible scripts. It currently feels like an awkward spot mixed in with the Linux files. Any one have thoughts on if that is ok or files should be re-arranged? | 
| The changes LGTM | 
3643cc3    to
    f9971e6      
    Compare
  
    | Yes this is ready. I just did a re-base to clean up the commits to a reasonable set and tested an image with kubernetes-sigs/cluster-api-provider-azure#1036 | 
| /test pull-azure-sigs | 
| Changes LGTM as well @jsturtevant @CecileRobertMichon | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
will leave it open until tomorrow EOD unless there are any objections
| No objections here. | 
f9971e6    to
    bde0dc2      
    Compare
  
    | /test pull-azure-sigs | 
Co-authored-by: Peri Thompson <[email protected]>
bde0dc2    to
    9fd8bf6      
    Compare
  
    | /test pull-azure-sigs | 
| /lgtm great work @jsturtevant 🎉 | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jsturtevant, ksubrmnn The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
Initial support for configuring Windows nodes for CAPI. This is the first step for Windows support as described in Windows Proposal in CAPI: kubernetes-sigs/cluster-api#3616 and partly solves #30.
The current scripts work to create an image but I am still testing that the image works with a provider like CAPZ. I wanted to open the PR to get feedback on the setup.Update: now tested via CAPZ #382 (comment)A few notes:
config/windowsto keep it cleaner since there were so many different setting between Windows/linux.ansiblefolder. Didn't include that change here to minimize the diff.Looking forward to feedback.