Add support for native windows commands #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, any documentation need to be changed in the compatibility markdown? |
|
No, I think the matrix is still accurate. I mean, it would be very welcome to see a unit test to accompany this, obviously, but there is an integration test covering this currently. |
|
Agree the documentation is accurate. Added unit tests. Thanks! |
petemounce
approved these changes
Oct 17, 2020
|
Looks great, Thanks for the contribution! |
|
FYI: This just got released in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Fixes #632
Uses Native tools to execute commands on the host machine which enables better support for windows. This requires the paths for the command files to be in correct format with
\instead of/.