Grpc mutlitple mirrors #2256
Grpc mutlitple mirrors #2256
Conversation
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
cncf-cla: yes
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
Seems reasonable to me to mimic HTTPRoute behavior here 👍🏽
robscott
left a comment
robscott
left a comment
There was a problem hiding this comment.
Thanks @LiorLieberman!
/cc @gnossen
|
@robscott: GitHub didn't allow me to request PR reviews from the following users: gnossen. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM, nice work. /approved |
Co-authored-by: Rob Scott <[email protected]>
|
Thanks @LiorLieberman! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnossen, LiorLieberman, robscott, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 participants
What this PR does / why we need it:
Following #2199 this PR adds the same functionality to GRPCRoute
Which issue(s) this PR fixes:
Related to #2109
Does this PR introduce a user-facing change?: