generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 618
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
What happened:
HttpRouteFilters Docs and webhook do not match.
The docs/api field description say:
gateway-api/apis/v1beta1/httproute_types.go
Lines 204 to 205 in f2cd9bb
| // Specifying a core filter multiple times has unspecified or | |
| // implementation-specific conformance. |
And it seems that the webhook does not allow multiple features from the same type (unless it is HTTPRouteFilterExtensionRef)
gateway-api/apis/v1beta1/validation/httproute.go
Lines 137 to 142 in f2cd9bb
| for filterType, count := range counts { | |
| if count > 1 { | |
| errs = append(errs, field.Invalid(path.Child("filters"), filterType, "cannot be used multiple times in the same rule")) | |
| } | |
| } | |
| return errs |
What you expected to happen:
Expected both to match.
Would vote for changing the webhook to allow and clarify in the docs that repeatable is implementation-specific.
cc: @howardjohn
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.