Skip to content

HttpRouteFilters Docs and webhook do not match.  #2109

@LiorLieberman

Description

@LiorLieberman

What happened:
HttpRouteFilters Docs and webhook do not match.

The docs/api field description say:

// Specifying a core filter multiple times has unspecified or
// implementation-specific conformance.

And it seems that the webhook does not allow multiple features from the same type (unless it is HTTPRouteFilterExtensionRef)

for filterType, count := range counts {
if count > 1 {
errs = append(errs, field.Invalid(path.Child("filters"), filterType, "cannot be used multiple times in the same rule"))
}
}
return errs

What you expected to happen:

Expected both to match.

Would vote for changing the webhook to allow and clarify in the docs that repeatable is implementation-specific.

cc: @howardjohn

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions