🌱 Deduplicate extension filtering and response validation logic #12905
+26
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duplication Previously, CallAllExtensions duplicated the extension filtering logic (namespace matching, registry listing, GVK lookup) that already existed in GetAllExtensions. This refactoring makes CallAllExtensions call GetAllExtensions to get the list of matching handlers. Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
k8s-ci-robot
added
area/runtime-sdk
70 tasks
|
/test pull-cluster-api-e2e-main |
|
Thank you! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 32e7ae2023a9a5f429726c521ac1636b907c1537
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors the runtime client to eliminate code duplication in two places:
CallAllExtensionsnow usesGetAllExtensionsinstead of duplicating the filtering logicvalidateResponseStatushelper functionAddresses: #12857 (comment)
Part of: #12291
/area runtime-sdk