Skip to content

✨ KCP: Implement CanUpdateMachine #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2025
Merged

✨ KCP: Implement CanUpdateMachine #12857

merged 2 commits into from
Oct 21, 2025
+2,271 −185

Conversation

@sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12291

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 14, 2025
@sbueringer sbueringer mentioned this pull request Oct 14, 2025
Open
70 tasks
@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch from 3f4384b to d2a13a0 Compare October 14, 2025 15:10
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 14, 2025
@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch 4 times, most recently from a583d63 to da532cf Compare October 15, 2025 10:18
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 15, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch from da532cf to df285a0 Compare October 15, 2025 11:26
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch 2 times, most recently from ff62816 to bea83b4 Compare October 16, 2025 09:55
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch from bea83b4 to 89a86da Compare October 16, 2025 10:59
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch from 89a86da to db704b2 Compare October 16, 2025 11:02
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-can-update-machine branch from db704b2 to 33c245f Compare October 16, 2025 12:40
@sbueringer sbueringer changed the title [WIP] ✨ KCP: Implement CanUpdateMachine ✨ KCP: Implement CanUpdateMachine Oct 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer mentioned this pull request Oct 17, 2025
Open
fabriziopandini
fabriziopandini reviewed Oct 17, 2025
View reviewed changes
sbueringer
sbueringer commented Oct 18, 2025
View reviewed changes
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 99ea82d link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer sbueringer mentioned this pull request Oct 20, 2025
Open
@fabriziopandini
Copy link
Member

Great work!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e19bb04abf88d58739a091878177a7b9f4ac8a46

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit f370aec into kubernetes-sigs:main Oct 21, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 21, 2025
@sbueringer sbueringer deleted the pr-kcp-can-update-machine branch October 21, 2025 09:51
@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @fabriziopandini