Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Apr 1, 2023

Pull Request for Issue #40284 .

Summary of Changes

This pull request (PR) adds the "CAN FAIL" installer hint to the drop column statement in the "4.3.0-2023-03-28.sql" update script.

The reason is that with PR #40228 the update SQL script "4.3.0-2023-02-15.sql" has been changed, too, so the column does not exist when not updating from a 4.3.0 beta 4 or rc 1 but an older version.

In addition, this PR fixes the value of the checked out column of the Guided Tours module installed with the "4.3.0-2023-02-15.sql" script on update.

Testing Instructions

Update from a 4.2.9 or a current 4.2-dev branch to the last 4.3-dev nightly build to reproduce the issue, and to the update package or custom update URL built by drone for this PR to test the fix.

Actual result BEFORE applying this Pull Request

SQL error about column not existing.

Com_checkin shows something checked out in the modules table. Checking in database shows that it is the Guided Tours module.

Expected result AFTER applying this Pull Request

No SQL error.

Nothing is checked out in com_checkin after the update.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [4.3] Add "CAN FAIL" installer hint to drop column statement in "4.3.0-2023-03-28.sql" update script [4.3] Add "CAN FAIL" installer hint to drop column statement in "4.3.0-2023-03-28.sql" update script and fix checked out Apr 1, 2023
@richard67 richard67 changed the title [4.3] Add "CAN FAIL" installer hint to drop column statement in "4.3.0-2023-03-28.sql" update script and fix checked out [4.3] Fix SQL error "Can't Drop 'asset_id'; check that column/key exists" and checked out Guided Tours module when updating from 4.2.9 or older Apr 1, 2023
@sdwjoomla
Copy link
Contributor

I have tested this item ✅ successfully on ce538b6

new 4.2.9 instance
installed update file from 40286
installed without error


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.

@alikon
Copy link
Contributor

alikon commented Apr 2, 2023

I have tested this item ✅ successfully on ce538b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.

@alikon
Copy link
Contributor

alikon commented Apr 2, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 2, 2023
@khu5h1
Copy link
Contributor

khu5h1 commented Apr 2, 2023

I have tested this item ✅ successfully on ce538b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Apr 2, 2023
@obuisard obuisard merged commit 3765fdf into joomla:4.3-dev Apr 2, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2023
@obuisard
Copy link
Contributor

obuisard commented Apr 2, 2023

Thank you Richard @richard67 for the PR and all for testing.

@richard67 richard67 deleted the 4.3-dev-fix-update-sql-for-guided-tours branch April 2, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants