-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Guided tours removal of tour permissions #40228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2023
Contributor
|
I have tested this item ✅ successfully on 99f68b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228. |
Quy
reviewed
Mar 30, 2023
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-02-15.sql
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on 99f68b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request as a replacement for #40208 and #40220. It compiles some of the corrections made and simplifies the code.
Summary of Changes
Individual tours have permissions in the original Guided Tours PR.
However, tours don't really require such granularity in most cases and the issues linked to having tours in the asset table outweighs the need for such permissions.
This PR removes permissions for individual tours.
Testing Instructions
Ideally, create several user profiles with limited permissions and make sure those having limited permissions can't access the functionality they are denied.
Actual result BEFORE applying this Pull Request
Tours can have individual permissions
Expected result AFTER applying this Pull Request
Tours and steps only get the general permissions of the component.
Link to documentations
Please select:
Documentation link for docs.joomla.org: need to remove the permissions section for tours at Guided Tours: New or Edit Tour
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed