Skip to content

Conversation

@obuisard
Copy link
Contributor

Pull Request as a replacement for #40208 and #40220. It compiles some of the corrections made and simplifies the code.

Summary of Changes

Individual tours have permissions in the original Guided Tours PR.
However, tours don't really require such granularity in most cases and the issues linked to having tours in the asset table outweighs the need for such permissions.
This PR removes permissions for individual tours.

Testing Instructions

Ideally, create several user profiles with limited permissions and make sure those having limited permissions can't access the functionality they are denied.

Actual result BEFORE applying this Pull Request

Tours can have individual permissions

Expected result AFTER applying this Pull Request

Tours and steps only get the general permissions of the component.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: need to remove the permissions section for tours at Guided Tours: New or Edit Tour

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 99f68b1

Tested new installation, tested update, it is still working well. Try to edit tours, steps, all still work. Did a quick code review, too


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.

@khu5h1
Copy link
Contributor

khu5h1 commented Mar 30, 2023

I have tested this item ✅ successfully on 99f68b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.

@Quy
Copy link
Contributor

Quy commented Mar 30, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 30, 2023
@sdwjoomla sdwjoomla added this to the Joomla! 4.3.0 milestone Mar 31, 2023
@sdwjoomla sdwjoomla merged commit 427f41d into joomla:4.3-dev Mar 31, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2023
Denitz pushed a commit to Denitz/joomla-cms that referenced this pull request Apr 1, 2023
@obuisard obuisard deleted the guided-tours-permissions branch October 29, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants