Skip to content

Update enum values for OpenHIM Apps type #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

medchedli
Copy link
Contributor

@medchedli medchedli commented Jan 10, 2024

This pull request proposes modifying the Apps schema's type attribute to:

  • New enum values: Replace ['link', 'embedded'] with ['internal', 'external', 'esmodule'].

However, I'd like to open a discussion about alternative naming options :

  • built-in : OpenHIM Console core module or internal pages
  • shortcut: link to an external web page or app
  • in-browser-module: link to one of Jembi's or third-party bundled ESModules

@medchedli medchedli requested a review from bradsawadye January 25, 2024 08:25
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ef8191) 86.78% compared to head (60cdd8c) 86.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   86.78%   86.76%   -0.02%     
==========================================
  Files          89       89              
  Lines        6024     6024              
==========================================
- Hits         5228     5227       -1     
- Misses        796      797       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I have no problem with these new names.

TobitMisoi

This comment was marked as duplicate.

Copy link
Collaborator

@drizzentic drizzentic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@medchedli medchedli merged commit 201308a into master Feb 5, 2024
@medchedli medchedli deleted the update-appSchema branch February 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants