Update enum values for OpenHIM Apps type (#1216)

* Update enum values for OpenHIM Apps type

* Update API test scripts and bump OpenHIM Core version

Author: medchedli

package.json

@@ -1,7 +1,7 @@
 {
   "name": "openhim-core",
   "description": "The OpenHIM core application that provides logging and routing of http requests",
-  "version": "8.4.0",
+  "version": "8.4.1",
   "main": "./lib/server.js",
   "bin": {
     "openhim-core": "./bin/openhim-core.js"

src/model/apps.js

@@ -14,7 +14,7 @@ const AppSchema = new Schema({
   icon: String,
   type: {
     type: String,
-    enum: ['link', 'embedded']
+    enum: ['internal', 'external', 'esmodule']
   },
   category: String,
   access_roles: [String],

test/integration/appsAPITests.js

@@ -20,7 +20,7 @@ describe('API Integration Tests', () => {
       name: 'Test app',
       description: 'An app for testing the app framework',
       icon: 'data:image/png;base64, <base64>',
-      type: 'link',
+      type: 'external',
       category: 'Operations',
       access_roles: ['test-app-user'],
       url: 'http://test-app.org/app',

test/unit/appsTest.js

@@ -32,7 +32,7 @@ describe('Apps', () => {
         name: 'Test app1',
         description: 'An app for testing the app framework',
         icon: 'data:image/png;base64, <base64>',
-        type: 'link',
+        type: 'external',
         category: 'Operations',
         access_roles: ['test-app-user'],
         url: 'http://test-app.org/app1',