Fix: Pull fileNode file name from airtable metadata #374
Conversation
This makes the fileNode pull its name from the airtable metadata instead of the remote file, because when an airtable user changes the file name, airtable does not rename the original file. This change makes file name changes in airtable usable in the fileNode instead of needing to download, rename, and re-upload the file.
ryan-talus
changed the title
|
Thanks for this! Do you know if this option was added at a later date? Considering which versions of Gatsby we are able to support with this change. I think regardless we can figure out how to best land this, so would you also add a change file? 🙏 |
|
@jbolda Thanks! I've added the change file. The name option was added in this PR: Which was merged Jan 23, 2019, into Let me know if there's anything else I should add to this PR! |
|
@jbolda Is there anything else helpful I could add to this pull request? |
|
@jbolda Is there anything I could do to help push this forward? |
|
Sorry, all my attention has been on driving other projects forward in a big way. Yea, with those requirements, this should be fine as a patch. Let's get this merged in. Thanks again! @all-contributors please add @ryan-talus for code bors merge |
|
I've put up a pull request to add @ryan-talus! 🎉 |
374: Fix: Pull fileNode file name from airtable metadata r=jbolda a=ryan-talus This makes the fileNode pull `name` from the airtable metadata instead of the remote file, because when an airtable user changes the file name, airtable does not rename the original file. This change makes file name changes in airtable usable in the fileNode instead of needing to download, rename, and re-upload the file. Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan Zimmerman <[email protected]>
|
Build failed: |
416: docs: add ryan-talus as a contributor for code r=jbolda a=allcontributors[bot] Add `@ryan-talus` as a contributor for code. This was requested by jbolda [in this comment](#374 (comment)) Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
jbolda
left a comment
jbolda
left a comment
There was a problem hiding this comment.
Sorry it took so long to get back to this. I took some vacation this week, so finally have some time to get back to resolving this. When we went to merge it in, the CI failed on Windows. I think with these suggestions, we can close this out.
|
I went ahead and applied the suggestions. Doesn't feel like it is worth dragging it out as I have made y'all wait long enough. bors merge |
|
Build succeeded: |
2 participants
This makes the fileNode pull
namefrom the airtablemetadata instead of the remote file, because when an airtable
user changes the file name, airtable does not rename the original
file. This change makes file name changes in airtable usable in
the fileNode instead of needing to download, rename, and
re-upload the file.