-
-
Notifications
You must be signed in to change notification settings - Fork 43
Fix: Pull fileNode file name from airtable metadata #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
34c7235
Pull file name from airtable metadata
ryan-talus 4c107f6
Adding change file
ryan-talus 0d8c3f2
Copy/pasted from the example without changing the type, oops!
ryan-talus fea9711
Merge branch 'jbolda:main' into main
ryan-talus 0220c92
Merge branch 'jbolda:main' into main
ryan-talus d7200c0
apply suggestions from code review
jbolda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "gatsby-source-airtable": patch | ||
| --- | ||
|
|
||
| This makes the fileNode pull `name` from the airtable metadata instead of the | ||
| remote file, because when an airtable user changes the file name, airtable does | ||
| not rename the original url. This change makes file name changes in airtable | ||
| usable in the fileNode instead of needing to download, rename, and re-upload the | ||
| file. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.