[Issue #420] Update NBGeneratedPhoneNumberMetaData for extern variable definitions #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e definitions * Move the metadata variable implementations to a .m file, and leave the definitions in the header file as external variables * Move the Testing Metadata to a common location * Support loading the metadata from different locations based on whether SPM or the project file are being used to run the tests * Update the GeneratePhoneNumberHeader.sh script to honor the new locations * Consolidate the Package.swift files to just support a minimum of Swift 5.5 * Prepare the Package.swift file to support all the libraries currently supported by cocoapods: Geocoding & ShortNumber * Maintain the current level of public/private header files These changes were built off of PR #406 by https://github.com/ccomsi
This was referenced Nov 7, 2025
Collaborator
Author
|
@FONickReichard or @iziz - would appreciate reviews on this... |
Collaborator
Author
|
@iziz - Thanks again for granting me privs to the repo! I have this one PR, and then probably 3 more to update the repo and get the demo app and everything working 100%. Then I'd love to be able to publish the updates to the cocoapods' spec repo (probably as a 1.3.0). Any chance you would want to grant that permission to me? Or I could work with you to have to do the publishing once everything is ready and tagged. -Thanks! |
ashoemakeora
approved these changes
Nov 7, 2025
ashoemakeora
left a comment
ashoemakeora
left a comment
There was a problem hiding this comment.
Per request from @LowAmmo, lending a hand to review these changes as I work on the same app that consumes this code
This was referenced Nov 10, 2025
LowAmmo
changed the title
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e definitions
These changes were built off of PR #406 by https://github.com/ccomsi