Development #2
Merged
Development #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiFiManagerParameter allocates but never frees __value!
use malloc/free for WiFiManagerParameter* array instead of hard coding.
conflicts resolved
paramid must be alphanumeric and adds {I} token support to use ids as input names if we make that optional.
Document that parameter id cannot contain spaces
make WIFI_MANAGER_MAX_PARAMS customizable
I dont feel like resolving conflicts
Fix travis builds, add esp32 builds
wifi save now no longer uses settimeout timeout
… portal from autoConnect()
allow automatic config portal to be disabled
not sure what use this is, as getChipRevision is usually the same anyway... shrug
removed test menu output, removed ref , not sure why I put that there....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.