Skip to content

Conversation

@mtiutiu
Copy link
Contributor

@mtiutiu mtiutiu commented Jan 22, 2018

I think it's pretty useful to have this parameter customizable so that users can change it from outside if required (e.g platformio, make, etc).

For example when using platformio I can set this in platformio.ini:
build_flags = -DWIFI_MANAGER_MAX_PARAMS=20

This allows me to change the value at compile time without modifying the library source code. I also provided the default value for it when not defined outside or somewhere else - you can see that in the code changes that I want to propose.

This approach can be used for other defines in this library source code if desired/required.

Very nice work btw regarding this library - very useful. Thanks.

@tablatronix tablatronix merged commit a3a04f1 into tzapu:master Feb 1, 2018
@tablatronix
Copy link
Collaborator

Note that setting this is no longer needed, as memory is autoallocated for params now

@mtiutiu
Copy link
Contributor Author

mtiutiu commented Feb 8, 2018

I noticed that. So yeah it kinda makes no sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants