Add validation webhook for BIOSVersion type
#325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
4 times, most recently
from
633d2d9 to
be87ea9
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBiosVersion
branch
from
b914fe6 to
c790aac
Compare
Contributor
Author
|
to be merged after PR #311 |
Nuckal777
reviewed
May 8, 2025
Contributor
Nuckal777
left a comment
Nuckal777
left a comment
There was a problem hiding this comment.
Thanks, looks good in general.
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
from
be87ea9 to
e56362f
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBiosVersion
branch
from
c790aac to
69a59cd
Compare
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
9 times, most recently
from
e79597d to
837af1a
Compare
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
2 times, most recently
from
77652d0 to
255fdb3
Compare
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
2 times, most recently
from
7560bae to
edc61bd
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBiosVersion
branch
2 times, most recently
from
c0dcaef to
dad5ef5
Compare
nagadeesh-nagaraja
force-pushed
the
biosVersion
branch
from
94a5498 to
d466b32
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBiosVersion
branch
from
dad5ef5 to
b062457
Compare
afritzler
changed the title
biosVersion resourcesBIOSVersion resource
afritzler
changed the title
BIOSVersion resourceBIOSVersion type
afritzler
approved these changes
May 26, 2025
Nuckal777
approved these changes
May 27, 2025
afritzler
pushed a commit
that referenced
this pull request
May 28, 2025
* Add biosVersion resource and controller * Change types and fix logic to handle vendor variations * Stabilize some unit tests * fix some of flaky test in server and biossetting controller * remove bool from Spec and update finalizers * Rebase with the testHelpers * Revert some unwanted changes * Do not error when waiting for verifications * Some cosmetic issue fixes * Review comments change to follow naming conventions * Fix docs and reconcile error when job has stalled * small adjustments * Add validation webhook for `BIOSVersion` type (#325) * Add webhook for biosVersion resources * add resource delete logic in the webhook * Add ResyncInterval in unit tests * Use Pointer and mark required fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314