Skip to content

Conversation

@nagadeesh-nagaraja
Copy link
Contributor

@nagadeesh-nagaraja nagadeesh-nagaraja commented Apr 29, 2025

Fixes #305

@nagadeesh-nagaraja nagadeesh-nagaraja self-assigned this Apr 29, 2025
@nagadeesh-nagaraja nagadeesh-nagaraja moved this to In Progress in Roadmap Apr 29, 2025
@github-actions github-actions bot added size/XXL api-change documentation Improvements or additions to documentation labels Apr 29, 2025
@nagadeesh-nagaraja nagadeesh-nagaraja force-pushed the biosVersion branch 8 times, most recently from 1f9b4ac to 3474577 Compare April 30, 2025 18:04
@nagadeesh-nagaraja nagadeesh-nagaraja marked this pull request as ready for review May 8, 2025 06:29
@nagadeesh-nagaraja nagadeesh-nagaraja force-pushed the biosVersion branch 3 times, most recently from 633d2d9 to be87ea9 Compare May 8, 2025 09:03
@nagadeesh-nagaraja
Copy link
Contributor Author

Screenshot 2025-05-08 at 11 17 34 Screenshot 2025-05-08 at 11 24 57

Copy link
Contributor

@Nuckal777 Nuckal777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@nagadeesh-nagaraja
Copy link
Contributor Author

sorry, had to rebase with main after the TestHelpers changed.

this is the starting commit after previous rounds of review :)
remove bool from Spec and update finalizers 0e609d0

* Add webhook for biosVersion resources

* add resource delete logic in the webhook
@afritzler afritzler added the enhancement New feature or request label May 28, 2025
@afritzler afritzler merged commit 09f5832 into main May 28, 2025
15 of 16 checks passed
@afritzler afritzler deleted the biosVersion branch May 28, 2025 07:56
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change area/metal-automation documentation Improvements or additions to documentation enhancement New feature or request size/XXL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement CRD and Controller for BIOSVersion Add BIOSVersion type and controller

6 participants