Skip to content

chore(*): Update external rust SDK types #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

chore(*): Update external rust SDK types #5195

wants to merge 15 commits into from

Conversation

@DaughterOfMars
Copy link
Contributor

@DaughterOfMars DaughterOfMars commented Feb 4, 2025 •
edited
Loading

Description of change

Updates the external rust SDK types lib to use iotaledger/iota-rust-sdk#26.

NOTE: This currently is pointing to the PR commit. This will have to be updated once it is merged in that repo.

@DaughterOfMars DaughterOfMars requested review from a team as code owners February 4, 2025 14:30
@vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 7:10pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 7:10pm
apps-backend ⬜️ Skipped (Inspect) Feb 14, 2025 7:10pm
wallet-dashboard ⬜️ Skipped (Inspect) Feb 14, 2025 7:10pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Feb 4, 2025
@muXxer
Copy link
Contributor

muXxer commented Feb 4, 2025

What is the reasoning to remove all the Versions from the structs?

@DaughterOfMars
Copy link
Contributor Author

DaughterOfMars commented Feb 4, 2025

What is the reasoning to remove all the Versions from the structs?

IIRC they were removed in the upstream changes

@DaughterOfMars DaughterOfMars requested a review from a team as a code owner February 4, 2025 19:42
muXxer
muXxer requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes related to any version number removal.

ConsensusCommitPrologueV1 also exists on current upstream.
AuthenticatorStateUpdateV1 was introduced by my team in #3173

@DaughterOfMars
Copy link
Contributor Author

DaughterOfMars commented Feb 5, 2025

Please revert the changes related to any version number removal.

ConsensusCommitPrologueV1 also exists on current upstream. AuthenticatorStateUpdateV1 was introduced by my team in #3173

Should I apply this to the external repo as well? It is removed upstream there.

@muXxer
Copy link
Contributor

muXxer commented Feb 5, 2025 •
edited
Loading

Should I apply this to the external repo as well? It is removed upstream there.

I think it would cleaner, yes.

@DaughterOfMars
Copy link
Contributor Author

DaughterOfMars commented Feb 5, 2025

Should I apply this to the external repo as well? It is removed upstream there.

I think it would cleaner, yes.

done :)

miker83z
miker83z reviewed Feb 6, 2025
View reviewed changes
@DaughterOfMars DaughterOfMars requested a review from muXxer February 6, 2025 13:32
muXxer
muXxer requested changes Feb 6, 2025
View reviewed changes
@DaughterOfMars DaughterOfMars requested a review from muXxer February 7, 2025 14:02
@vercel vercel bot temporarily deployed to Preview – apps-backend February 14, 2025 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 14, 2025 19:09 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Jun 30, 2025
@DaughterOfMars DaughterOfMars deleted the dev-tools/update-sdk-types branch October 15, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miker83z miker83z miker83z left review comments

@piotrm50 piotrm50 piotrm50 approved these changes

@muXxer muXxer muXxer approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

+1 more reviewer

@samuel-rufi samuel-rufi samuel-rufi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@DaughterOfMars @muXxer @piotrm50 @samuel-rufi @miker83z @Alex6323 @iota-ci