EmAgent (NEW) #751
Merged
EmAgent (NEW) #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
added
enhancement
Closed
# Conflicts: # src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala
# Conflicts: # CHANGELOG.md
# Conflicts: # src/main/scala/edu/ie3/simona/io/grid/CsvGridSource.scala
# Conflicts: # CHANGELOG.md
danielfeismann
requested changes
Mar 18, 2024
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Just some minor questions and some suggestions. Thanks so far!
src/main/scala/edu/ie3/simona/model/em/PrioritizedFlexStrat.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/em/PrioritizedFlexStratSpec.scala
Outdated
Show resolved
Hide resolved
Better ScalaDoc Co-authored-by: Daniel Feismann <[email protected]>
Using DefaultQuantities everywhere where possible
…c.scala Fixing test case Co-authored-by: Daniel Feismann <[email protected]>
danielfeismann
approved these changes
Mar 19, 2024
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Looks very good in my opinion. This extension takes simona one big step further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
Some remarks:
EmAgentITwon't work until we have dealt with Consider scaling factor with flex options #734 in PR New scaling of participants #765GridAgentControlleris not finished yet and also waiting for the PSDM release, where the structure ofEmInputs/SystemParticipantInputs has changedEmAgentITthat involves a battery storage which I removed for now. We should remember to inlude that test once storages are merged. -> will be included with StorageAgent PRPhaseSwitchnow. This has to be still put to use inSimonaSim, which I'd wait to deal with until ConvertigSimonaSimto a typed actor, improving failure handling #746 is merged.FlexSignalFromExcelincluded. Probably not 😄 Could be included later (in some form), is still available in all/#tbw branches