Skip to content

Harmonized result file naming and time columns #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2020
Merged

Harmonized result file naming and time columns #233

merged 7 commits into from
Oct 30, 2020

Conversation

@ckittl
Copy link
Member

@ckittl ckittl commented Oct 30, 2020

Closes #175 and fixes #149

@ckittl ckittl added the enhancement New feature or request label Oct 30, 2020
@ckittl ckittl added this to the Version 2.0 milestone Oct 30, 2020
@ckittl ckittl requested review from a team and mia-krause October 30, 2020 16:46
@ckittl ckittl self-assigned this Oct 30, 2020
@ckittl ckittl force-pushed the ck/#175-harmonizedTimeFields branch from 17988b8 to 20db9db Compare October 30, 2020 16:50
@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #233 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #233      +/-   ##
============================================
+ Coverage     77.87%   77.96%   +0.08%     
- Complexity     1834     1835       +1     
============================================
  Files           233      234       +1     
  Lines          7445     7451       +6     
  Branches        723      721       -2     
============================================
+ Hits           5798     5809      +11     
+ Misses         1234     1230       -4     
+ Partials        413      412       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/edu/ie3/datamodel/io/sink/InfluxDbSink.java 78.37% <0.00%> (ø) 22.00% <0.00%> (ø%)
...amodel/io/factory/result/ThermalResultFactory.java 82.35% <0.00%> (ø) 7.00% <0.00%> (ø%)
...model/models/result/thermal/ThermalSinkResult.java 50.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
...model/models/result/thermal/ThermalUnitResult.java 36.84% <0.00%> (ø) 3.00% <0.00%> (ø%)
...odel/io/factory/result/ConnectorResultFactory.java 89.36% <0.00%> (ø) 10.00% <0.00%> (ø%)
...s/result/system/ElectricalEnergyStorageResult.java 36.84% <0.00%> (ø) 3.00% <0.00%> (?%)
...a/edu/ie3/datamodel/io/csv/FileNamingStrategy.java 97.77% <0.00%> (+0.01%) 53.00% <0.00%> (ø%)
...n/java/edu/ie3/datamodel/models/StandardUnits.java 96.00% <0.00%> (+0.08%) 1.00% <0.00%> (ø%)
...c/main/java/edu/ie3/datamodel/io/TarballUtils.java 72.82% <0.00%> (+1.08%) 19.00% <0.00%> (ø%)
...u/ie3/datamodel/models/result/system/EvResult.java 100.00% <0.00%> (+38.09%) 3.00% <0.00%> (-1.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a11b40...cccdb75. Read the comment docs.

@johanneshiry
Copy link
Member

johanneshiry commented Oct 30, 2020

!test

johanneshiry
johanneshiry approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johanneshiry
Copy link
Member

johanneshiry commented Oct 30, 2020

!test

@johanneshiry johanneshiry merged commit 5ab6166 into dev Oct 30, 2020
@johanneshiry johanneshiry deleted the ck/#175-harmonizedTimeFields branch October 30, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mia-krause mia-krause Awaiting requested review from mia-krause

1 more reviewer

@johanneshiry johanneshiry johanneshiry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ckittl ckittl

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 2.0

Development

Successfully merging this pull request may close these issues.

Rename all time based columns to "time" Harmonized file naming for result entities

3 participants

@ckittl @johanneshiry