Skip to content

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Sep 5, 2024

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-8229)
Edition master

Screenshots update in Dev-doc

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@julitafalcondusza julitafalcondusza marked this pull request as ready for review September 9, 2024 12:40
Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionnally, few images' width could be reduced by cutting out middle emptiness.

I love improvement like delete_confirmation.png in content_management_guide.md or notification3.png in notifications.md

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've put a lot of effort into this and it shows 😄

I have a couple of small suggestions, but it's great - thank you for taking care of this.

@julitafalcondusza julitafalcondusza merged commit 5a59c02 into master Sep 16, 2024
5 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-8229 branch September 16, 2024 11:56
julitafalcondusza added a commit that referenced this pull request Sep 19, 2024
* Screenshots updated

* New screenshots & updates

* Updates

* Update: screenshots and content

* Duplicate filename removed

* Duplicate filename removed

* Screenshots updated

* Fixes after review
adriendupuis added a commit that referenced this pull request Feb 15, 2025
adriendupuis added a commit that referenced this pull request Feb 15, 2025
- …/images/img/… from #1864
- Duplicated to a better dir in #2487
@adriendupuis adriendupuis mentioned this pull request Feb 17, 2025
7 tasks
adriendupuis added a commit that referenced this pull request Feb 19, 2025
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138
adriendupuis added a commit that referenced this pull request Feb 19, 2025
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138

(cherry picked from commit 21d66a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants