Skip to content

IBX-3766 [CLOUD] Fastly Image Optimizer Integration #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 26, 2023
Merged

IBX-3766 [CLOUD] Fastly Image Optimizer Integration #1864

merged 11 commits into from
Jan 26, 2023

Conversation

MagdalenaZuba
Copy link
Contributor

Question Answer
JIRA Ticket https://issues.ibexa.co/browse/IBX-3766
Versions 4.4

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

mnocon
mnocon reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nattfarinn is also adding support for configuration with env variables (ibexa/recipes-dev#48), it might be worth mentioning that

Also, Fastly is calling the service Optimizer, it might be worth to unify all the Optimiser/Optimizer variations

docs/content_management/images/fastly_io.md Outdated

To be able to configure this feature you need:

- [Platform.sh project](https://docs.platform.sh/guides/ibexa/deploy.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK Fastly IO (and Fastly integration) does not need a Platform.sh project, the site can be hosted somewhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took these requirements from Platform.sh doc as it was specified as a baseline in the Ibexa feature requirements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add other options if we have any alternatives

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be any hosting, even an old computer in the basement - right now it sounds to me as if it's a Platform.sh-only feature

Nattfarinn
Nattfarinn reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@Nattfarinn Nattfarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments by Marek are valid.

mnocon
mnocon reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd remove the mention that Platform.sh is needed for Fastly IO and we're good to go 😄

docs/content_management/images/fastly_io.md Outdated

To be able to configure this feature you need:

- [Platform.sh project](https://docs.platform.sh/guides/ibexa/deploy.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be any hosting, even an old computer in the basement - right now it sounds to me as if it's a Platform.sh-only feature

mnocon
mnocon approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DominikaK DominikaK self-assigned this Jan 26, 2023
DominikaK
DominikaK approved these changes Jan 26, 2023
View reviewed changes
@MagdalenaZuba MagdalenaZuba merged commit 22f8d64 into master Jan 26, 2023
@MagdalenaZuba MagdalenaZuba deleted the fastly_io branch January 26, 2023 12:40
MagdalenaZuba added a commit that referenced this pull request Jan 26, 2023
@MagdalenaZuba
IBX-3766 [CLOUD] Fastly Image Optimizer Integration (#1864)
63fa1a0
adriendupuis added a commit that referenced this pull request Feb 15, 2025
@adriendupuis
rm docs/content_management/images/img/fastly_variations.png
38990e1 
- …/images/img/… from #1864
- Duplicated to a better dir in #2487
@adriendupuis adriendupuis mentioned this pull request Feb 17, 2025
Merged
7 tasks
adriendupuis added a commit that referenced this pull request Feb 19, 2025
@adriendupuis
Clean ressources (#2615)
21d66a4 
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138
adriendupuis added a commit that referenced this pull request Feb 19, 2025
@adriendupuis
Clean ressources (#2615)
0a07db7 
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138

(cherry picked from commit 21d66a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

+2 more reviewers

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@DominikaK DominikaK DominikaK approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@DominikaK DominikaK

Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MagdalenaZuba @Nattfarinn @mnocon @DominikaK