Skip to content

[Chores] Update node supported version to 24 #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+55 −56
Open

[Chores] Update node supported version to 24 #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a8cce
chore(node): update to node 24
mgermerie Nov 3, 2025
d69b640
chore: update caniuse-lite
mgermerie Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v4
- name: Use Node.js 22.17
uses: actions/setup-node@v4
- uses: actions/checkout@v5
- name: Use Node.js 24
uses: actions/setup-node@v6
with:
node-version: 22.17
node-version: 24
cache: 'npm'

# Install packages
Expand Down Expand Up @@ -90,11 +90,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v4
- name: Use Node.js 22.17
uses: actions/setup-node@v4
- uses: actions/checkout@v5
- name: Use Node.js 24
uses: actions/setup-node@v6
with:
node-version: 22.17
node-version: 24
cache: 'npm'

# Install packages
Expand All @@ -106,7 +106,7 @@ jobs:
run: npm run transpile

- name: Test ${{ matrix.package }}
run: npm run test-with-coverage_lcov --workspace ${{ matrix.package}}
run: npm run test-with-coverage_lcov --workspace packages/${{ matrix.path }}
- name: Coveralls Parallel
uses: coverallsapp/github-action@v2
with:
Expand Down Expand Up @@ -136,11 +136,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v4
- name: Use Node.js 22.17
uses: actions/setup-node@v4
- uses: actions/checkout@v5
- name: Use Node.js 24
uses: actions/setup-node@v6
with:
node-version: 22.17
node-version: 24
cache: 'npm'

# Install packages
Expand All @@ -149,7 +149,7 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: dist-itowns

Expand All @@ -171,17 +171,17 @@ jobs:
contents: write
steps:

- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
# fetch all branches
fetch-depth: 0

# Configure git user for later command induced commits
- uses: fregante/setup-git-user@v1
- uses: fregante/setup-git-user@v2

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: 22.17
node-version: 24
registry-url: https://registry.npmjs.org/

- run: npm ci
Expand Down Expand Up @@ -227,7 +227,7 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: dist-itowns

Expand All @@ -253,7 +253,7 @@ jobs:
# Deploy to itowns.github.io LTS
- name: Deploy LTS to itowns.github.io
if: ${{ startsWith(github.event.head_commit.message, 'release v' ) }}
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
external_repository: iTowns/itowns.github.io
Expand All @@ -268,7 +268,7 @@ jobs:
# since it is not possible to use the same deploy key to simultaneously deploy two different
# folders on iTowns/itowns.github.io (the release bundle on previous step and this one.
if: ${{ !startsWith(github.event.head_commit.message, 'release v' ) }}
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
external_repository: iTowns/itowns.github.io
Expand All @@ -286,12 +286,12 @@ jobs:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Use Node.js 22.17
uses: actions/setup-node@v4
- name: Use Node.js 24
uses: actions/setup-node@v6
with:
node-version: 22.17
node-version: 24

- name: Message commit
run: echo "is RELEASE => ${{ github.event.head_commit.message }} !!"
Expand All @@ -313,7 +313,7 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: dist-itowns

Expand Down
55 changes: 27 additions & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/Geographic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"lint": "eslint \"src/**/*.{js,ts,tsx}\" \"test/**/*.js\"",
"transpile": "tsc && cross-env BABEL_DISABLE_CACHE=1 babel src --out-dir lib --extensions .js,.ts",
"test-unit": "npm run base-test-unit test/unit",
"base-test-unit": "cross-env BABEL_DISABLE_CACHE=1 mocha --import=../../config/babel-register/register.mjs",
"base-test-unit": "cross-env BABEL_DISABLE_CACHE=1 NODE_OPTIONS=--no-experimental-strip-types mocha --import=../../config/babel-register/register.mjs",
"test-with-coverage": "c8 -n src -r html cross-env npm run test-unit",
"test-with-coverage_lcov": "c8 -n src --reporter=lcov cross-env npm run test-unit",
"watch": "npm run transpile -- --watch",
Expand Down
2 changes: 1 addition & 1 deletion packages/Main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"types": "tsc && tsc-alias",
"transpile": "npm run types && cross-env BABEL_DISABLE_CACHE=1 babel src --out-dir lib --extensions .js,.ts",
"test-unit": "npm run base-test-unit test/unit",
"base-test-unit": "cross-env BABEL_DISABLE_CACHE=1 mocha --timeout 5000 --file test/unit/bootstrap.js --import=../../config/babel-register/register.mjs",
"base-test-unit": "cross-env BABEL_DISABLE_CACHE=1 NODE_OPTIONS=--no-experimental-strip-types mocha --timeout 5000 --file test/unit/bootstrap.js --import=../../config/babel-register/register.mjs",
"test-with-coverage": "c8 -n src -r html cross-env npm run test-unit",
"test-with-coverage_lcov": "c8 -n src --reporter=lcov cross-env npm run test-unit",
"watch": "npm run transpile -- --watch",
Expand Down