Skip to content

Update quality tooling for formatting #21480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 6, 2023
Merged

Update quality tooling for formatting #21480

merged 9 commits into from
Feb 6, 2023

Conversation

@sgugger
Copy link
Collaborator

@sgugger sgugger commented Feb 6, 2023 •
edited
Loading

What does this PR do?

This updates the quality tools for 2023. Mainly:

  • use black 23
  • replace isort and flake8 by ruff, which is faster and merges imports contrarily to isort
  • change a few rules in the isorting

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 6, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger changed the title Result of black 23.1 Update quality tooling for formatting Feb 6, 2023
@sgugger sgugger requested a review from LysandreJik February 6, 2023 21:05
LysandreJik
LysandreJik approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sgugger sgugger merged commit 6f79d26 into main Feb 6, 2023
@sgugger sgugger deleted the update_quality branch February 6, 2023 23:10
@Wauplin Wauplin mentioned this pull request Feb 7, 2023
Merged
@sgugger sgugger mentioned this pull request Feb 7, 2023
Merged
@ArthurZucker ArthurZucker mentioned this pull request Feb 7, 2023
Closed
5 tasks
@patrickvonplaten patrickvonplaten mentioned this pull request Feb 7, 2023
Merged
This was referenced Feb 7, 2023
Merged
Merged
@mariosasko mariosasko mentioned this pull request Feb 9, 2023
Merged
1 task
@alvarobartt alvarobartt mentioned this pull request Feb 19, 2023
Merged
@echarlaix echarlaix mentioned this pull request Apr 4, 2023
Merged
@alexcpn alexcpn mentioned this pull request Apr 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sgugger @HuggingFaceDocBuilderDev @LysandreJik