-
Notifications
You must be signed in to change notification settings - Fork 844
Update formatting tooling #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
LysandreJik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for the change @Wauplin!
LGTM
|
Thanks both for the reviews and thanks @sgugger for pushing for it :) |
Related to
transformers's PR (see related internal discussion)This updates the quality tools for 2023. Mainly:
Basically: align with
transformers's settings. Goal is to get a consistent coding experience for contributors.@sgugger I listed the few changes compared to
transformersconfig..ruff_cache/to .gitignore => cache folder that is generated byruffhfhas it's all done byruff)[tool.ruff.isort]) => same here. Haven't seen any different with or without those configs (since we removed flake8/isort from makefile)Bonus: here is the vscode settings that I now use.