Fix custom arabic tasks #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Hi @albertvillanova ! Could you review this one? It's a simple fix :) |
albertvillanova
approved these changes
Dec 12, 2024
Member
There was a problem hiding this comment.
If I understand correctly, #433 already removed these parameters because they are deprecated.
But they were left in some code lines and this PR removes them completely.
Thank you.
Member
Author
|
Yep! It also fixes the init of an arabic task which was broken :) |
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
* removed unused params * fix issue with task function
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
* removed unused params * fix issue with task function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a wrong def in custom arabic tasks + wraps up #433 .
Should fix #438