Skip to content

Commit 0135c2e

Browse files
authored
Fix custom arabic tasks (#440)
* removed unused params * fix issue with task function
1 parent ca2fdcb commit 0135c2e

File tree

6 files changed

+1
-50
lines changed

6 files changed

+1
-50
lines changed

community_tasks/_template.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,6 @@ def __init__(
9999
suite=["community"],
100100
generation_size=-1,
101101
stop_sequence=None,
102-
output_regex=None,
103-
frozen=False,
104102
)
105103

106104

community_tasks/arabic_evals.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@ def __init__(
109109
suite=["community"],
110110
generation_size=-1,
111111
stop_sequence=None,
112-
output_regex=None,
113-
frozen=False,
114112
trust_dataset=True,
115113
version=0,
116114
)
@@ -174,8 +172,6 @@ def __init__(
174172
suite=["community"],
175173
generation_size=-1,
176174
stop_sequence=None,
177-
output_regex=None,
178-
frozen=False,
179175
trust_dataset=True,
180176
version=0,
181177
)
@@ -241,8 +237,6 @@ def __init__(
241237
suite=["community"],
242238
generation_size=-1,
243239
stop_sequence=None,
244-
output_regex=None,
245-
frozen=False,
246240
trust_dataset=True,
247241
version=0,
248242
)
@@ -299,8 +293,6 @@ def __init__(
299293
suite=["community"],
300294
generation_size=-1,
301295
stop_sequence=None,
302-
output_regex=None,
303-
frozen=False,
304296
trust_dataset=True,
305297
version=0,
306298
)
@@ -361,8 +353,6 @@ def __init__(
361353
suite=["community"],
362354
generation_size=-1,
363355
stop_sequence=[],
364-
output_regex=None,
365-
frozen=False,
366356
trust_dataset=True,
367357
version=0,
368358
)
@@ -423,9 +413,7 @@ def arabic_exams_pfn(line, task_name: str = None):
423413
def alghafa_pfn(line, task_name: str = None):
424414
question = line["query"]
425415
answer_index = int(line["label"])
426-
# Dynamically determining the choices by excluding '__few_shots', 'query' and 'label'
427-
choices_keys = [key for key in line.keys() if key not in ["query", "label", "__few_shots"]]
428-
choices = [line[key] for key in choices_keys]
416+
choices = [line[key] for key in ["sol1", "sol2", "sol3", "sol4"]]
429417

430418
instruction = "الأسئلة التالية هي أسئلة متعددة الإختيارات مع الجواب الصحيح\n\n"
431419
query = f"{instruction}السؤال: {question}\n"
@@ -461,8 +449,6 @@ def __init__(
461449
suite=["community"],
462450
generation_size=-1,
463451
stop_sequence=None,
464-
output_regex=None,
465-
frozen=False,
466452
trust_dataset=True,
467453
version=0,
468454
)
@@ -839,8 +825,6 @@ def __init__(
839825
suite=["community"],
840826
generation_size=-1,
841827
stop_sequence=None,
842-
output_regex=None,
843-
frozen=False,
844828
trust_dataset=True,
845829
version=0,
846830
)

docs/source/adding-a-custom-task.mdx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,6 @@ class CustomSubsetTask(LightevalTaskConfig):
107107
suite=["community"],
108108
generation_size=-1,
109109
stop_sequence=None,
110-
output_regex=None,
111-
frozen=False,
112110
)
113111
SUBSET_TASKS = [CustomSubsetTask(name=f"mytask:{subset}", hf_subset=subset) for subset in SAMPLE_SUBSETS]
114112
```
@@ -154,13 +152,6 @@ Here is a list of the parameters and their meaning:
154152
for your generation
155153
- `metric` (list), the metrics you want to use for your evaluation (see next
156154
section for a detailed explanation)
157-
- `output_regex` (str), A regex string that will be used to filter your
158-
generation. (Generative metrics will only select tokens that are between the
159-
first and the second sequence matched by the regex. For example, for a regex
160-
matching `\n` and a generation `\nModel generation output\nSome other text`
161-
the metric will only be fed with `Model generation output`)
162-
- `frozen` (bool), for now, is set to False, but we will steadily pass all
163-
stable tasks to True.
164155
- `trust_dataset` (bool), set to True if you trust the dataset.
165156

166157

docs/source/saving-and-reading-results.mdx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,7 @@ The detail file contains the following columns:
170170
"stop_sequence": [
171171
"Question="
172172
],
173-
"output_regex": null,
174173
"num_samples": null,
175-
"frozen": false,
176174
"suite": [
177175
"lighteval"
178176
],

examples/nanotron/custom_evaluation_tasks.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,6 @@ def __init__(
267267
generation_size=40,
268268
trust_dataset=True,
269269
stop_sequence=None,
270-
output_regex=None,
271-
frozen=False,
272270
):
273271
super().__init__(
274272
name=name,
@@ -282,8 +280,6 @@ def __init__(
282280
few_shots_select=few_shots_select,
283281
suite=suite,
284282
generation_size=generation_size,
285-
output_regex=output_regex,
286-
frozen=frozen,
287283
trust_dataset=trust_dataset,
288284
stop_sequence=(stop_sequence if stop_sequence is not None else ["\n"]),
289285
)
@@ -370,8 +366,6 @@ def __init__(
370366
generation_size=-1,
371367
trust_dataset=True,
372368
stop_sequence=None,
373-
output_regex=None,
374-
frozen=False,
375369
):
376370
super().__init__(
377371
name=name,
@@ -387,8 +381,6 @@ def __init__(
387381
generation_size=generation_size,
388382
trust_dataset=trust_dataset,
389383
stop_sequence=(stop_sequence if stop_sequence is not None else ["\n"]),
390-
output_regex=output_regex,
391-
frozen=frozen,
392384
)
393385

394386

@@ -487,8 +479,6 @@ def __init__(
487479
generation_size=4,
488480
trust_dataset=True,
489481
stop_sequence=None,
490-
output_regex=None,
491-
frozen=False,
492482
):
493483
super().__init__(
494484
name=name,
@@ -504,8 +494,6 @@ def __init__(
504494
generation_size=generation_size,
505495
trust_dataset=trust_dataset,
506496
stop_sequence=(stop_sequence if stop_sequence is not None else ["\n"]),
507-
output_regex=output_regex,
508-
frozen=frozen,
509497
)
510498

511499

@@ -623,8 +611,6 @@ def __init__(
623611
generation_size=-1,
624612
trust_dataset=True,
625613
stop_sequence=None,
626-
output_regex=None,
627-
frozen=False,
628614
):
629615
super().__init__(
630616
name=name,
@@ -640,8 +626,6 @@ def __init__(
640626
generation_size=generation_size,
641627
trust_dataset=trust_dataset,
642628
stop_sequence=(stop_sequence if stop_sequence is not None else ["\n"]),
643-
output_regex=output_regex,
644-
frozen=frozen,
645629
)
646630

647631

examples/nanotron/custom_task.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ def mmlu_anatomy(line):
8282
generation_size=5,
8383
metric=[Metrics.loglikelihood_acc_single_token],
8484
stop_sequence=["\n"],
85-
output_regex=None,
86-
frozen=False,
8785
),
8886
LightevalTaskConfig(
8987
name="mmlu:anatomy_signs",
@@ -98,7 +96,5 @@ def mmlu_anatomy(line):
9896
generation_size=5,
9997
metric=[Metrics.loglikelihood_acc_single_token],
10098
stop_sequence=["\n"],
101-
output_regex=None,
102-
frozen=False,
10399
),
104100
]

0 commit comments

Comments
 (0)