Compatability with latest hw-kafka-client version #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* conduit * hw-kafka-client
Author
|
@dsturnbull @newhoggy @joshgodsiff @tmcgilchrist |
Author
Author
|
@AlexeyRaga since you looked at my last PR in hw-kafka-avro, would you have some time to look at this one? There doesn't seem to be much activity in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
hw-kafka-conduitfails to build with the latesthw-kafka-clientversion (5.0.0), whereKafka.Producer.produceMessageBatchhas been removed.Also, the
conduit-extradependency seems redundant (at least with the latestconduitversion, so I removed it.Since this is a breaking change (removal of
kafkaBatchSinkNoClose), this PR bumps the major version to3.0.0.