Skip to content

Compatability with latest hw-kafka-client version #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Compatability with latest hw-kafka-client version #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53980e
Remove redundant conduit-extra dependency + remove kafkaBatchSinkNoClose
Oct 11, 2022
837f751
Update version and version-bounds
Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions hw-kafka-conduit.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cabal-version: 2.2

name: hw-kafka-conduit
version: 2.7.0
version: 3.0.0
synopsis: Conduit bindings for hw-kafka-client
homepage: https://github.com/haskell-works/hw-kafka-conduit
bug-reports: https://github.com/haskell-works/hw-kafka-conduit/issues
Expand Down Expand Up @@ -52,10 +52,9 @@ library
, bifunctors
, bytestring
, containers
, conduit
, conduit-extra
, conduit >= 1.3.4 && < 1.4
, exceptions
, hw-kafka-client >= 2.5
, hw-kafka-client >= 2.5 && < 5.1
, mtl
, resourcet
, transformers
Expand All @@ -73,7 +72,6 @@ test-suite kafka-client-conduit-test
, bytestring
, containers
, conduit
, conduit-extra
, extra
, hspec
, hw-kafka-client >= 2.5
Expand Down
19 changes: 1 addition & 18 deletions src/Kafka/Conduit/Sink.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Kafka.Conduit.Sink
( module X
, kafkaSink, kafkaSinkAutoClose, kafkaSinkNoClose, kafkaBatchSinkNoClose
, kafkaSink, kafkaSinkAutoClose, kafkaSinkNoClose
, commitOffsetsSink, flushThenCommitSink
) where

Expand Down Expand Up @@ -51,23 +51,6 @@ kafkaSinkNoClose prod = go
Nothing -> go
Just err -> return (Just err)

-- | Creates a batching Sink for a given `KafkaProducer`.
-- The producer will NOT be closed automatically.
kafkaBatchSinkNoClose :: MonadIO m
=> KafkaProducer
-> ConduitT [ProducerRecord] Void m [(ProducerRecord, KafkaError)]
kafkaBatchSinkNoClose prod = go
where
go = do
mbMsg <- await
case mbMsg of
Nothing -> return []
Just msgs -> do
res <- produceMessageBatch prod msgs
case res of
[] -> go
xs -> return xs

-- | Creates a kafka producer for given properties and returns a Sink.
--
-- This method of creating a Sink represents a simple case
Expand Down