Apply analyzer suggestions #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
commented
Apr 26, 2024
Member
|
@jnyrup is there any analyzer rule you think we can enforce in the config? |
jnyrup
commented
Apr 26, 2024
Contributor
Author
jnyrup
left a comment
jnyrup
left a comment
There was a problem hiding this comment.
RCS analyzers are from Roslynator.Analyzers
The additional analyzers from Roslyn can be enabled by having a newer SDK and e.g. <AnalysisLevel>8.0</AnalysisLevel>
https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props
kblok
reviewed
Apr 27, 2024
jnyrup
commented
Apr 28, 2024
jnyrup
commented
Apr 29, 2024
kblok
reviewed
Apr 29, 2024
Member
|
@jnyrup I'll land this PR. Feel free to create any follow-up PR. Thanks! |
Contributor
Author
|
I have no further suggestions to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #2615 I noticed some other things.