[Breaking] Replace WebClient with HttpClient #2615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/hardkoded/puppeteer-sharp into migrate-from-webclient-to-httpclient
jnyrup
reviewed
Apr 26, 2024
Co-authored-by: Jonas Nyrup <[email protected]>
novicov
reviewed
Jun 6, 2024
| using var response = await client.SendAsync(requestMessage).ConfigureAwait(false); | ||
| return response.StatusCode == HttpStatusCode.OK; | ||
| } | ||
| catch (WebException) |
There was a problem hiding this comment.
@kblok WebException needs to be changed to HttpRequestException
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will help us support more platforms.
Breaking change
BrowserFetcheris not disposable anymore and it no longer provides aDownloadProgressChangedevent.closes #1884