GRH suggestion voltage level refacto #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghazwarhili
changed the base branch from
main
to
refactor-voltage-level-topology
EtienneLt
reviewed
Oct 21, 2025
| .identifiableShortCircuit(ExtensionUtils.toIdentifiableShortCircuit(voltageLevel)) | ||
| .build(); | ||
| if (voltageLevel.getTopologyKind().equals(TopologyKind.NODE_BREAKER)) { | ||
| VoltageLevelFormInfos barSectionsInfos = getVoltageLevelBusBarSectionsInfos(voltageLevel); |
There was a problem hiding this comment.
Suggested change
| VoltageLevelFormInfos barSectionsInfos = getVoltageLevelBusBarSectionsInfos(voltageLevel); | |
| VoltageLevelFormInfos busBarSectionsInfos = getVoltageLevelBusBarSectionsInfos(voltageLevel); |
|
|
||
| SWITCHES("switches"), | ||
| FEEDER_BAYS("feeder_bays"), | ||
| BUSBAR_SECTIONS("busbar_sections"); |
There was a problem hiding this comment.
@etiennehomer is it good for you ? we send a list of enum to the back to dertermine what we want
| public static BusBarSectionsInfos getBusBarSectionsInfos(VoltageLevel voltageLevel) { | ||
| Map<Integer, Integer> nbSectionsPerBusbar = new HashMap<>(); | ||
| List<BusBarSectionFormInfos> busbarSectionInfos = new ArrayList<>(); | ||
| BusBarSectionsInfos busBarSectionsInfos = BusBarSectionsInfos.builder() |
There was a problem hiding this comment.
maybe you can keep the builder and call build() only at the end of the method ?
| VoltageLevel voltageLevel = network.getVoltageLevel(voltageLevelId); | ||
| if (voltageLevel.getTopologyKind().equals(TopologyKind.NODE_BREAKER)) { | ||
| return TopologyUtils.getTopologyInfos(voltageLevel); | ||
| TopologyInfos topologyInfos = TopologyInfos.builder().build(); |
There was a problem hiding this comment.
same you can use the builder, fill the selected fields and then call .build()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.