refactor topology infos and create new endpoint #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
|
etiennehomer
reviewed
Oct 8, 2025
| return feederBayInfos; | ||
| } | ||
|
|
||
| private static TopologyInfos.TopologyInfosBuilder<?, ?> createDefaultTopologyInfosBuilder() { |
There was a problem hiding this comment.
Create an empty object nope ? This can return false data
There was a problem hiding this comment.
@ghazwarhili what do you think ?
| int maxBusbarIndex = 1; | ||
| int maxSectionIndex = 1; | ||
| boolean busbarSectionPositionFound = true; | ||
| for (BusbarSection bbs : voltageLevel.getNodeBreakerView().getBusbarSections()) { |
There was a problem hiding this comment.
That would be nice to have a dedicated method for busbarSectionInfos
There was a problem hiding this comment.
but it's not the purpose of the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.