enhance: export custom nextjs/socket.io server #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix production NextJS builds - normalize import formatting Signed-off-by: Nick Hale <[email protected]>
Package and export a function for creating the custom combination NextJS/socket.io server so the UI can be more easily imported by other projects. Signed-off-by: Nick Hale <[email protected]>
tylerslaton
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
non-blocking for this pr, but...
What's your opinion about making this a TypeScript file? A part of the socket server being so bad is that it ignore all the other TS conventions in the app since its in common js.
The package version ranges specified in package.json cause peer dependency conflicts when package-lock.json is removed. Since npm's dependency resolution doesn't consider the versions tracked in package-lock.json, any project that depends on the UI will need to resolve these issues. To fix this, pin the versions of problematic packages to the versions currently set in package-lock.json. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/export-ui-server
branch
from
8cdad2f to
67a41e8
Compare
Since the THREADS_DIR environment variable is retrieved on package import, changes that dependents make to it before startAppServer is called are ignored. To fix this, load the environment variable immediately before it's used instead. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/export-ui-server
branch
from
7b9a4df to
9b50bdd
Compare
thedadams
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.