Fix checkstyle issues in gcloud-java-core #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| * | ||
| * Implementation must provide a public no-arg constructor. | ||
| * Loading of a factory implementation is done via {@link java.util.ServiceLoader}. | ||
| * A base interface for all service RPC factories. Implementation must provide a public no-arg |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Related to core cleanup, I'm seeing testConstructor() and testChunkSize() in BaseWriterChannelTest throwing IOExceptions that may be unnecessary; do you think we can remove there here? |
|
Feel free to merge after considering the IOException comment. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
🤖 I have created a release *beep* *boop* --- ## [3.1.2](googleapis/java-dataproc@v3.1.1...v3.1.2) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#870](googleapis/java-dataproc#870)) ([d738702](googleapis/java-dataproc@d738702)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
…-ai to v2.6.2 (#871) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | `2.6.0` -> `2.6.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuOSIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC45In0=-->
](https://renovatebot.com){kind=link}
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
…-plugin to v3.4.1 (#871) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE2MS4xIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.6.8](https://togithub.com/googleapis/java-kms/compare/v2.6.7...v2.6.8) (2022-10-03) ### Dependencies * Update dependency certifi to v2022.9.24 ([#868](https://togithub.com/googleapis/java-kms/issues/868)) ([15aa78b](https://togithub.com/googleapis/java-kms/commit/15aa78b96591e1af3d8df0f68f931866d1c57cdf)) * Update dependency charset-normalizer to v2.1.1 ([#872](https://togithub.com/googleapis/java-kms/issues/872)) ([eefde67](https://togithub.com/googleapis/java-kms/commit/eefde67472fcc22e5aa88e621ae854cad97a2564)) * Update dependency click to v8.1.3 ([#873](https://togithub.com/googleapis/java-kms/issues/873)) ([984cf8c](https://togithub.com/googleapis/java-kms/commit/984cf8c164960a91b22dd7c216262b73bd2629cf)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#894](https://togithub.com/googleapis/java-kms/issues/894)) ([cd63d9b](https://togithub.com/googleapis/java-kms/commit/cd63d9b0422427d1cfb6025fa7a598ebb73433b6)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.7 ([#892](https://togithub.com/googleapis/java-kms/issues/892)) ([aab16df](https://togithub.com/googleapis/java-kms/commit/aab16dfb84796db09a5a6fce969d40ae50e33236)) * Update dependency gcp-releasetool to v1.8.8 ([#869](https://togithub.com/googleapis/java-kms/issues/869)) ([f7b2ec1](https://togithub.com/googleapis/java-kms/commit/f7b2ec14a266f67b76cf2bfc710e3c89bfab9b1a)) * Update dependency google-api-core to v2.10.1 ([#874](https://togithub.com/googleapis/java-kms/issues/874)) ([0eff788](https://togithub.com/googleapis/java-kms/commit/0eff788116ee07b259c682e8243acb3dbc40a2ef)) * Update dependency google-cloud-core to v2.3.2 ([#870](https://togithub.com/googleapis/java-kms/issues/870)) ([00fd66e](https://togithub.com/googleapis/java-kms/commit/00fd66e2d86beb32c83b7f8f5659840b964b6e76)) * Update dependency google-cloud-storage to v2.5.0 ([#876](https://togithub.com/googleapis/java-kms/issues/876)) ([3ab4bdc](https://togithub.com/googleapis/java-kms/commit/3ab4bdc35468a921db44a359c453cb7c9ee1b565)) * Update dependency google-crc32c to v1.5.0 ([#877](https://togithub.com/googleapis/java-kms/issues/877)) ([dbbca81](https://togithub.com/googleapis/java-kms/commit/dbbca815cc5f04df1d6f1d41976e86624d4b2c28)) * Update dependency googleapis-common-protos to v1.56.4 ([#871](https://togithub.com/googleapis/java-kms/issues/871)) ([f146017](https://togithub.com/googleapis/java-kms/commit/f1460171967a2138cd1de1e14a8101e671d23e42)) * Update dependency importlib-metadata to v4.12.0 ([#886](https://togithub.com/googleapis/java-kms/issues/886)) ([7783160](https://togithub.com/googleapis/java-kms/commit/7783160bebb8922c50fe1c4f365497a6eab90b42)) * Update dependency jeepney to v0.8.0 ([#887](https://togithub.com/googleapis/java-kms/issues/887)) ([da6b14a](https://togithub.com/googleapis/java-kms/commit/da6b14ad3d1df84042f677d651157fc6e6a14380)) * Update dependency jinja2 to v3.1.2 ([#888](https://togithub.com/googleapis/java-kms/issues/888)) ([40bc730](https://togithub.com/googleapis/java-kms/commit/40bc73026f0158df4a29e69110eed863bf3ae587)) * Update dependency keyring to v23.9.3 ([#889](https://togithub.com/googleapis/java-kms/issues/889)) ([6d07f4d](https://togithub.com/googleapis/java-kms/commit/6d07f4d68ee2eb0346c0d5f90620c7e244bc52ae)) * Update dependency pyjwt to v2.5.0 ([#880](https://togithub.com/googleapis/java-kms/issues/880)) ([f686c49](https://togithub.com/googleapis/java-kms/commit/f686c499bec8cb560f54f4cf5d8079a4b93f59d7)) * Update dependency requests to v2.28.1 ([#881](https://togithub.com/googleapis/java-kms/issues/881)) ([3e82aca](https://togithub.com/googleapis/java-kms/commit/3e82aca7ac76821491d5453a09f69ff1e62e51c1)) * Update dependency zipp to v3.8.1 ([#883](https://togithub.com/googleapis/java-kms/issues/883)) ([faf3c84](https://togithub.com/googleapis/java-kms/commit/faf3c845e0c31e08a05254586ae84decc5c10ef3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to yoshi-code-bot/google-cloud-java
that referenced
this pull request
Oct 6, 2022
…manager to v1.5.6 (googleapis#871) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-resourcemanager](https://togithub.com/googleapis/java-resourcemanager) | `1.5.5` -> `1.5.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
… to v1.42.2 (#871) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-bom](https://togithub.com/googleapis/google-http-java-client) | `1.42.1` -> `1.42.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-http-java-client</summary> ### [`v1.42.2`](https://togithub.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#​1422-httpsgithubcomgoogleapisgoogle-http-java-clientcomparev1421v1422-2022-07-13) [Compare Source](https://togithub.com/googleapis/google-http-java-client/compare/v1.42.1...v1.42.2) ##### Bug Fixes - enable longpaths support for windows test ([#​1485](https://togithub.com/googleapis/google-http-java-client/issues/1485)) ([#​1684](https://togithub.com/googleapis/google-http-java-client/issues/1684)) ([9d789f5](https://togithub.com/googleapis/google-http-java-client/commit/9d789f511b907c3970ed9845a4c092fe5458755d)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.3](googleapis/java-core@v2.8.2...v2.8.3) (2022-07-26) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v2 ([#868](googleapis/java-core#868)) ([fe7991d](googleapis/java-core@fe7991d)) * update dependency com.google.api:gax-bom to v2.18.4 ([#864](googleapis/java-core#864)) ([d4a8501](googleapis/java-core@d4a8501)) * update dependency com.google.api:gax-bom to v2.18.5 ([#876](googleapis/java-core#876)) ([e2c0c13](googleapis/java-core@e2c0c13)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#870](googleapis/java-core#870)) ([adf5af4](googleapis/java-core@adf5af4)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.2 ([#865](googleapis/java-core#865)) ([5dad1ea](googleapis/java-core@5dad1ea)) * update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#856](googleapis/java-core#856)) ([bb58609](googleapis/java-core@bb58609)) * update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#871](googleapis/java-core#871)) ([341b04e](googleapis/java-core@341b04e)) * update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#874](googleapis/java-core#874)) ([efe8c28](googleapis/java-core@efe8c28)) * update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#877](googleapis/java-core#877)) ([25bea6c](googleapis/java-core@25bea6c)) * update dependency io.grpc:grpc-bom to v1.48.0 ([#873](googleapis/java-core#873)) ([8bfee63](googleapis/java-core@8bfee63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.5](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.4...v3.0.5) (2022-10-20) ### Dependencies * Update dependency com.fasterxml.jackson:jackson-bom to v2.13.4.20221013 ([#868](https://togithub.com/googleapis/java-shared-dependencies/issues/868)) ([5c2a825](https://togithub.com/googleapis/java-shared-dependencies/commit/5c2a825c18af61784287dd41eba3a21be80bbe6b)) * Update dependency com.google.auth:google-auth-library-bom to v1.12.0 ([#870](https://togithub.com/googleapis/java-shared-dependencies/issues/870)) ([3e3a60d](https://togithub.com/googleapis/java-shared-dependencies/commit/3e3a60dfd45f08401ee3ac7a98007fae21d5bba6)) * Update dependency com.google.auth:google-auth-library-bom to v1.12.1 ([#871](https://togithub.com/googleapis/java-shared-dependencies/issues/871)) ([4d94c75](https://togithub.com/googleapis/java-shared-dependencies/commit/4d94c753b46d7f8c787b0efa21d7bc42b1ca1c6c)) * Update dependency com.google.cloud:grpc-gcp to v1.3.0 ([#867](https://togithub.com/googleapis/java-shared-dependencies/issues/867)) ([48ca222](https://togithub.com/googleapis/java-shared-dependencies/commit/48ca222a5e4d9f88737d4c4a4ee2a42a7145619e)) * Update dependency com.google.errorprone:error_prone_annotations to v2.16 ([#865](https://togithub.com/googleapis/java-shared-dependencies/issues/865)) ([d7a494d](https://togithub.com/googleapis/java-shared-dependencies/commit/d7a494dcd12a529121b74fd9fb9dfc679017f844)) * Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#872](https://togithub.com/googleapis/java-shared-dependencies/issues/872)) ([ebe5d5f](https://togithub.com/googleapis/java-shared-dependencies/commit/ebe5d5f27dbe4f12c06d3a69c14c74bbf4e76dd1)) * Update dependency gcp-releasetool to v1.8.10 ([#853](https://togithub.com/googleapis/java-shared-dependencies/issues/853)) ([5c6367a](https://togithub.com/googleapis/java-shared-dependencies/commit/5c6367a643f491d2ec04be58c1ff0eca5aa10904)) * Update dependency google-api-core to v2.10.2 ([#858](https://togithub.com/googleapis/java-shared-dependencies/issues/858)) ([bc91e8d](https://togithub.com/googleapis/java-shared-dependencies/commit/bc91e8df54f9d919a9e0dc69e61d52fd855a8dbf)) * Update dependency io.grpc:grpc-bom to v1.50.0 ([#866](https://togithub.com/googleapis/java-shared-dependencies/issues/866)) ([50039f4](https://togithub.com/googleapis/java-shared-dependencies/commit/50039f41bfba37e65685c4a5b279d3cb2a92f2c5)) * Update dependency io.grpc:grpc-bom to v1.50.1 ([#873](https://togithub.com/googleapis/java-shared-dependencies/issues/873)) ([9fb1561](https://togithub.com/googleapis/java-shared-dependencies/commit/9fb15613976f83c5545e2b664c488e9811c1f185)) * Update dependency org.checkerframework:checker-qual to v3.26.0 ([#852](https://togithub.com/googleapis/java-shared-dependencies/issues/852)) ([1e8cd60](https://togithub.com/googleapis/java-shared-dependencies/commit/1e8cd609b3be0cdd748a8fea6bc0fcb15d8f4c96)) * Update dependency org.threeten:threetenbp to v1.6.3 ([#869](https://togithub.com/googleapis/java-shared-dependencies/issues/869)) ([e992190](https://togithub.com/googleapis/java-shared-dependencies/commit/e9921900ec590e281b5ae6e16ab51e7bd67c1242)) * Update dependency typing-extensions to v4.4.0 ([#854](https://togithub.com/googleapis/java-shared-dependencies/issues/854)) ([c909a13](https://togithub.com/googleapis/java-shared-dependencies/commit/c909a13fa626eb387c8ee87b7cc22607cb9cf889)) * Update dependency zipp to v3.9.0 ([#859](https://togithub.com/googleapis/java-shared-dependencies/issues/859)) ([971b84e](https://togithub.com/googleapis/java-shared-dependencies/commit/971b84eb801699b585cd35300bed8d4fb65046d8)) * Update gax.version to v2.19.4 ([#875](https://togithub.com/googleapis/java-shared-dependencies/issues/875)) ([2eb7f3d](https://togithub.com/googleapis/java-shared-dependencies/commit/2eb7f3d6cf834c474dcdc99740f8cdabf50bca51)) * Update google.core.version to v2.8.21 ([#861](https://togithub.com/googleapis/java-shared-dependencies/issues/861)) ([2fda421](https://togithub.com/googleapis/java-shared-dependencies/commit/2fda4213796df086450fdc3d69d53a0bd1d59f46)) * Update google.core.version to v2.8.22 ([#879](https://togithub.com/googleapis/java-shared-dependencies/issues/879)) ([e4f9f9a](https://togithub.com/googleapis/java-shared-dependencies/commit/e4f9f9ad6373fb52c069985ca4390663ccdacb7d)) * Update iam.version to v1.6.3 ([#857](https://togithub.com/googleapis/java-shared-dependencies/issues/857)) ([6758373](https://togithub.com/googleapis/java-shared-dependencies/commit/675837378642f39fe55c0e30b62755b9185bee3d)) * Update iam.version to v1.6.4 ([#862](https://togithub.com/googleapis/java-shared-dependencies/issues/862)) ([1e1bc34](https://togithub.com/googleapis/java-shared-dependencies/commit/1e1bc341c9dd0f8f5a2d14aa8dd52399b2ce71c1)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.