Skip to content

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Aug 6, 2025

This syncs cl/629836458.

From the CL:

This removes the requirement for proto3_json.dart to invoke outside code
(either via BuilderInfo or inheritance). This also improves tree shaking
of the proto3json helpers, since the proto3json callbacks attached to
BuilderInfo no longer retain those helpers.

osa1 added 2 commits August 6, 2025 11:17
This syncs cl/629836458.

From the CL:

This removes the requirement for proto3_json.dart to invoke outside code
(either via BuilderInfo or inheritance). This also improves tree shaking
of the proto3json helpers, since the proto3json callbacks attached to
BuilderInfo no longer retain those helpers.
@osa1 osa1 requested a review from devoncarew August 6, 2025 10:23
Copy link

github-actions bot commented Aug 6, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:protobuf 5.0.0 (error) pubspec version (5.0.0) and changelog (5.0.0-wip) don't agree
package:protoc_plugin 23.0.0 ready to publish protoc_plugin-v23.0.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Collaborator

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as already reviewed (This syncs cl/629836458).

However, we may consider rev'ing package:protobuf from 4.2.0-wip to 4.2.0 as a separate PR and publishing. That would capture the ~2 changes that are in head but not yet published.

@@ -1,5 +1,5 @@
name: protobuf
version: 4.2.0-wip
version: 5.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 5.0.0
version: 5.0.0-wip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add -wip that breaks dependency resolution in protoc_plugin because it needs to use 5.0.0 and apparently 5.0.0-wip is not considered 5.0.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Then not critical as we can choose to ignore the publishing validation failure. You could try a constraint of ^5.0.0-0 to allow pub get to continue - any -foo version will satisfy that - but we'd need to remember to switch to a regular stable constraint before an actual publish. No strong opinions here.

@osa1 osa1 mentioned this pull request Aug 11, 2025
@osa1 osa1 merged commit 086dfab into google:master Aug 12, 2025
12 checks passed
@osa1 osa1 deleted the cl629836458 branch August 12, 2025 08:10
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 14, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/6b4b2bc..ee5b2b2):
  ee5b2b2  2025-08-13  Greg Spencer  Stop reporting errors for non-zero exits (dart-lang/ai#262)

protobuf (https://github.com/dart-lang/protobuf/compare/0b73b0d..6e9c9f4):
  6e9c9f4  2025-08-12  Ömer Sinan Ağacan  Improve clone and deepCopy tests (google/protobuf.dart#1039)
  086dfab  2025-08-12  Ömer Sinan Ağacan  Make proto3_json.dart aware of well known types (google/protobuf.dart#1037)
  277b45a  2025-08-12  Ömer Sinan Ağacan  Release protobuf 4.2.0 (google/protobuf.dart#1038)

shelf (https://github.com/dart-lang/shelf/compare/2a46b4f..400fc39):
  400fc39  2025-08-11  Kevin Moore  [shelf_router_generator] latest deps, prepare release (dart-lang/shelf#480)

web (https://github.com/dart-lang/web/compare/72cdd84..4310354):
  4310354  2025-08-12  Nikechukwu  [interop] Add Support for JSDoc Documentation (dart-lang/web#435)

webdev (https://github.com/dart-lang/webdev/compare/94c172c..c0492f1):
  c0492f1b  2025-08-13  Srujan Gaddam  [dwds] Wait for scripts to be parsed on a hot restart and publish DWDS 25.0.0 (dart-lang/webdev#2667)
  595f8768  2025-08-13  Nicholas Shahan  [dwds] Cleanup unused null safety related fields (dart-lang/webdev#2660)
  b43030e2  2025-08-12  Jessy Yameogo  Implemented hot restart over websocket (dart-lang/webdev#2666)

Change-Id: I1cb2a0c2ed693bb740ab4c40ea70678b03eec596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445340
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants