Skip to content

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented Jul 31, 2025

No description provided.

@nshahan nshahan force-pushed the dwds-null-safety-cleanup branch from c72b594 to de79811 Compare August 1, 2025 17:17
@nshahan
Copy link
Contributor Author

nshahan commented Aug 1, 2025

@jyameo @bkonyi It seems like when the public APIs were deprecated we wanted to wait until the next major version to remove them. Do we have any other plans for a major version bump soon? I can wait to land this if we need to release another minor version first.

@nshahan nshahan requested review from bkonyi and jyameo August 1, 2025 18:48
@bkonyi
Copy link
Collaborator

bkonyi commented Aug 5, 2025

I see no reason why we couldn't do a major version bump. Can you also remove the deprecated parameter in dwds/lib/dart_web_debug_service.dart as well?

@nshahan
Copy link
Contributor Author

nshahan commented Aug 5, 2025

I see no reason why we couldn't do a major version bump. Can you also remove the deprecated parameter in dwds/lib/dart_web_debug_service.dart as well?

Done!

Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nshahan nshahan force-pushed the dwds-null-safety-cleanup branch from ba7afe8 to 72ed8cd Compare August 12, 2025 22:22
@nshahan nshahan merged commit 595f876 into main Aug 13, 2025
48 of 50 checks passed
@nshahan nshahan deleted the dwds-null-safety-cleanup branch August 13, 2025 14:47
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 14, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/6b4b2bc..ee5b2b2):
  ee5b2b2  2025-08-13  Greg Spencer  Stop reporting errors for non-zero exits (dart-lang/ai#262)

protobuf (https://github.com/dart-lang/protobuf/compare/0b73b0d..6e9c9f4):
  6e9c9f4  2025-08-12  Ömer Sinan Ağacan  Improve clone and deepCopy tests (google/protobuf.dart#1039)
  086dfab  2025-08-12  Ömer Sinan Ağacan  Make proto3_json.dart aware of well known types (google/protobuf.dart#1037)
  277b45a  2025-08-12  Ömer Sinan Ağacan  Release protobuf 4.2.0 (google/protobuf.dart#1038)

shelf (https://github.com/dart-lang/shelf/compare/2a46b4f..400fc39):
  400fc39  2025-08-11  Kevin Moore  [shelf_router_generator] latest deps, prepare release (dart-lang/shelf#480)

web (https://github.com/dart-lang/web/compare/72cdd84..4310354):
  4310354  2025-08-12  Nikechukwu  [interop] Add Support for JSDoc Documentation (dart-lang/web#435)

webdev (https://github.com/dart-lang/webdev/compare/94c172c..c0492f1):
  c0492f1b  2025-08-13  Srujan Gaddam  [dwds] Wait for scripts to be parsed on a hot restart and publish DWDS 25.0.0 (dart-lang/webdev#2667)
  595f8768  2025-08-13  Nicholas Shahan  [dwds] Cleanup unused null safety related fields (dart-lang/webdev#2660)
  b43030e2  2025-08-12  Jessy Yameogo  Implemented hot restart over websocket (dart-lang/webdev#2666)

Change-Id: I1cb2a0c2ed693bb740ab4c40ea70678b03eec596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445340
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants