Skip to content

Hide private instance state #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Hide private instance state #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5c8d5
Hide private instance state
dgraham Oct 18, 2019
83a1eab
Remove unused `this` value
dgraham Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
class RemoteInputElement extends HTMLElement {
currentQuery: string | null
debounceInputChange: (event: Event) => void
boundFetchResults: (event: Event) => void
const states = new WeakMap()

class RemoteInputElement extends HTMLElement {
constructor() {
super()
this.currentQuery = null
this.debounceInputChange = debounce(() => fetchResults(this))
this.boundFetchResults = () => fetchResults(this)
const fetch = fetchResults.bind(null, this, true)
const state = {currentQuery: null, oninput: debounce(fetch), fetch}
states.set(this, state)
}

static get observedAttributes() {
Expand All @@ -27,18 +25,24 @@ class RemoteInputElement extends HTMLElement {
input.setAttribute('autocomplete', 'off')
input.setAttribute('spellcheck', 'false')

input.addEventListener('focus', this.boundFetchResults)
input.addEventListener('change', this.boundFetchResults)
input.addEventListener('input', this.debounceInputChange)
const state = states.get(this)
if (!state) return

input.addEventListener('focus', state.fetch)
input.addEventListener('change', state.fetch)
input.addEventListener('input', state.oninput)
}

disconnectedCallback() {
const input = this.input
if (!input) return

input.removeEventListener('focus', this.boundFetchResults)
input.removeEventListener('change', this.boundFetchResults)
input.removeEventListener('input', this.debounceInputChange)
const state = states.get(this)
if (!state) return

input.removeEventListener('focus', state.fetch)
input.removeEventListener('change', state.fetch)
input.removeEventListener('input', state.oninput)
}

get input(): HTMLInputElement | HTMLTextAreaElement | null {
Expand All @@ -55,14 +59,17 @@ class RemoteInputElement extends HTMLElement {
}
}

async function fetchResults(remoteInput: RemoteInputElement, checkCurrentQuery: boolean = true) {
async function fetchResults(remoteInput: RemoteInputElement, checkCurrentQuery: boolean) {
const input = remoteInput.input
if (!input) return

const state = states.get(remoteInput)
if (!state) return

const query = input.value
if (checkCurrentQuery && remoteInput.currentQuery === query) return
if (checkCurrentQuery && state.currentQuery === query) return

remoteInput.currentQuery = query
state.currentQuery = query

const src = remoteInput.src
if (!src) return
Expand Down