Skip to content

Conversation

@dgraham
Copy link
Contributor

@dgraham dgraham commented Oct 18, 2019

Move private instance variables into a WeakMap so they aren't exposed as public API on the element. The private variables are removed from the type declaration file as well.

$ diff dist-master/index.d.ts dist/index.d.ts

<     currentQuery: string | null;
<     debounceInputChange: (event: Event) => void;
<     boundFetchResults: (event: Event) => void;

Move private instance variables into a WeakMap so they aren't exposed as
public API on the element.
@dgraham dgraham requested a review from a team October 18, 2019 17:48
@dgraham dgraham merged commit dff602d into master Oct 18, 2019
@dgraham dgraham deleted the private-state branch October 18, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants