C++: Remove an unneeded local-flow case #3385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case was added in dccc0f4. The surrounding code has changed a lot since then, and the case no longer seems to have an effect except to create some dead ends and possibly cycles in the local flow graph.
MathiasVP
approved these changes
May 1, 2020
I don't remember -- the code was in place before I took it over. But in any case, adding these extra edges for every kind of post-update node seems like a heavy-handed solution if the problem only had to do with constructor calls. |
jbj
added a commit
to jbj/ql
that referenced
this pull request
May 7, 2020
…-defbyref-to-field This is a partial merge from master. In particular, it takes in github#3382 and github#3385.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that the only affected tests are the ones that print every local data-flow step. The tests that go all the way from source to sink are not affected.