C++: Addresses may escape through call qualifiers #3382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clarify the docs on `Call` to decrease the likelyhood of such an omission happening again. The updated test reflects that `f1.operator()` lets the address of `f1` escape from the caller.
The check was supposed to check for constant type, not constant value. This fixes a false negative that appeared in `LargeParameter/test.cpp:106`.
MathiasVP
reviewed
May 1, 2020
Lambda invocations are apparently const. This was exposed by the fix in the previous commit.
MathiasVP
approved these changes
May 1, 2020
jbj
added a commit
to jbj/ql
that referenced
this pull request
May 7, 2020
…-defbyref-to-field This is a partial merge from master. In particular, it takes in github#3382 and github#3385.
geoffw0
added a commit
to geoffw0/ql
that referenced
this pull request
May 7, 2020
geoffw0
added a commit
to geoffw0/ql
that referenced
this pull request
May 7, 2020
jbj
added a commit
to jbj/ql
that referenced
this pull request
May 11, 2020
After github#3382 changed the escape analysis to model qualifiers as escaping, there was an imbalance in the SSA library, where `addressTakenVariable` excludes variables from SSA analysis if they have their address taken but are _not_ passed by reference. This showed up as a missing result in `TOCTOUFilesystemRace.ql`, demonstrated with a test case in github#3432. This commit changes the definition of "pass by reference" to include call qualifiers, which allows SSA modeling of variables that have member function calls on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarify the docs on
Callto decrease the likelyhood of such an omission happening again.The updated test reflects that
f1.operator()lets the address off1escape from the caller.