Skip to content

C#: Handle implicitly-typed stackallocs #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2020
Merged

C#: Handle implicitly-typed stackallocs #2803

merged 3 commits into from
Feb 10, 2020

Conversation

calumgrant
Copy link
Contributor

e.g.

var x = stackalloc[] { 1, 2, 3 };

This would previously throw an exception in the extractor because the expression type was not handled.

Note: conflicts with #2766

@calumgrant calumgrant added the C# label Feb 10, 2020
@calumgrant calumgrant requested a review from a team as a code owner February 10, 2020 11:37
hvitved
hvitved reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

@hvitved hvitved merged commit 2b2bb5d into github:master Feb 10, 2020
This was referenced May 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calumgrant @hvitved