C#: Extract stackalloc information
#2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/stackalloc
branch
2 times, most recently
from
e914679 to
d10471d
Compare
hvitved
added
the
depends on internal PR
hvitved
force-pushed
the
csharp/stackalloc
branch
from
f34790e to
96e71c7
Compare
calumgrant
reviewed
Feb 11, 2020
change-notes/1.24/analysis-csharp.md
Outdated
| @@ -27,7 +27,8 @@ The following changes in version 1.24 affect C# analysis in all applications. | |||
| ## Changes to code extraction | |||
|
|
|||
| * Tuple expressions, for example `(int,bool)` in `default((int,bool))` are now extracted correctly. | |||
| * Expression nullability flow state is extracted. | |||
| * Expression nullability flow state is extracted. | |||
| * `stackalloc` array creations are now extracted, and they are represented by the class `Stackalloc`. | |||
There was a problem hiding this comment.
This gives the impression that they weren't previously extracted at all. How about
In extraction:
- The difference between
stackallocarray creations normal array creations is extracted.
In changes to QL libraries:
stackallocarray creations are now represented by the QL classStackalloc. Previously they were represented by the classArrayCreation.
calumgrant
reviewed
Feb 11, 2020
| @@ -372,6 +372,11 @@ class ArrayCreation extends Expr, @array_creation_expr { | |||
| override string toString() { result = "array creation of type " + this.getType().getName() } | |||
| } | |||
|
|
|||
| /** A `stackalloc` array creation. */ | |||
There was a problem hiding this comment.
How about some sample C# code in the comment.
calumgrant
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.