C#: Remove FPs from cs/dereferenced-value-may-be-null
#2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/null-maybe-capture
branch
from
2fea704 to
12194a1
Compare
hvitved
force-pushed
the
csharp/null-maybe-capture
branch
from
12194a1 to
d5e212c
Compare
Apply a conservative approach by filtering out results for accesses to captured nullable values, when there is an (implicit) call to the capturing callable which is `null`-guarded. For example: ``` bool M(int? i, IEnumerable<int> @is) { if (i.HasValue) return @is.Any(j => j == i.Value); // GOOD return false; } ```
hvitved
force-pushed
the
csharp/null-maybe-capture
branch
from
d5e212c to
984e01e
Compare
michaelnebel
approved these changes
Feb 11, 2022
| static bool Ex43(int? i, IEnumerable<int> @is) | ||
| { | ||
| if (i.HasValue) | ||
| return @is.Any(j => j == i.Value); // GOOD |
There was a problem hiding this comment.
Nice to get this covered!
I think that C#10 also has some improvements related to definite assignment in terms of compiler warnings. Not sure, if there is also some support for nullable values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a conservative approach by filtering out results for accesses to captured nullable values, when there is an (implicit) call to the capturing callable which is
null-guarded. For example:Addresses #2485. I will run a dist-comparison and report the results.